Fix Jewel 0.12 Api usage, rollback to compose Splitpane, add InfoPanelConent #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… previous "2.0.0-SNAPSHOT".
…nel width (#3) Fixing [PKGS-1300](https://youtrack.jetbrains.com/issue/PKGS-1301/Compose-UI-Modules-tree-missing-scrollbars), [PKGS-1301](https://youtrack.jetbrains.com/issue/PKGS-1299/Compose-UI-Details-pane-is-missing-the-scrollbar), [PKGS-1284](https://youtrack.jetbrains.com/issue/PKGS-1284/Compose-UI-Details-panel-should-have-a-minimum-width) (cherry picked from commit ee4ce08)
(cherry picked from commit 3de49fe)
Refactored how the search results are retrieved in PackageListViewModel for better code simplicity and readability. Also, an unused import from Utils.kt has been removed improving code cleanliness. (cherry picked from commit 34c012d)
(cherry picked from commit 53b33be)
Removed time-based version suffix for snapshots in build.gradle.kts and replaced it with an approach dependent on the environment variables "RUN_NUMBER" and "RUN_ATTEMPT". Included these variables into the action workflow publish-snapshot.yml (cherry picked from commit 046267d)
(cherry picked from commit 6ffafc5)
Changed the `getValue` calls to direct map lookup operations in the PackageListViewModel. This approach ensures the code is more readable and allows us to handle null values with the Elvis operator, improving the overall robustness of the module variant and search result handling. (cherry picked from commit 17baa2b)
(cherry picked from commit 45f9cc7)
(cherry picked from commit 8f8a2e0)
(cherry picked from commit fdd1ef6)
(cherry picked from commit bff0144)
This commit removes the use of runCatching for API calls in PackageSearchApiPackageCache and instead handles potential failures further upstream. Additionally, introduced in the PackageSearchProjectService is a restart mechanism with a retry limit that prevents continuous restarts and avoids potential infinite loops. The PackageSearchGradleModelBuilder class also had an unused import that was removed. (cherry picked from commit 1732153)
(cherry picked from commit 318a3d7)
(cherry picked from commit d9a4fac)
This commit removes unused properties 'count' and 'attributes' from PackageList Builder. Additionally, a misnamed variable 'attriutes' has been renamed to 'attributes' across different methods enhancing code readability and maintenance. (cherry picked from commit 8b3796c)
…filtered by search query (cherry picked from commit 7c1ece2)
(cherry picked from commit d888fb8)
Integrated analytics event loggers to track events such as package installations, removed or upgrades, search requests, toggles, and GUI actions. This will aid in better understanding user behavior and improving features. The commit also includes changes for issues with module selection and aligning panels but focuses mainly on the introduction of analytics. (cherry picked from commit f074653)
(cherry picked from commit 1650b58)
(cherry picked from commit 4de36b9)
… access modifier The `packageVersionField` and `packageFromVersionField` were both refactored to use `StringValidatedByRegexp` instead of `StringValidatedByRegexpReference`. In addition, several preference fields were changed from public to private, enhancing the encapsulation of these fields.
Access level for PackageSearchEventsLogger has been changed to internal. Furthermore, several preference fields in PackageSearchEventsLogger have been changed to private - improving data encapsulation. Logging functions have also been shifted to internal to control the scope of their usage.
(cherry picked from commit a4d20a2)
… of "StringValidatedByRegexpReference"
The IntelliJ plugin version has been updated from "233-EAP-SNAPSHOT" to "2023.3".
The version of ideaGradlePlugin in the packagesearch.versions.toml file has been updated from 1.14.1 to 1.16.1. (cherry picked from commit 9efc988)
(cherry picked from commit f9e1a87)
Moved UI theme construction to a new file called `UiUtils.kt` for better organized code. Also improved how the Package Search plugin handles project refreshes and renames `isProjectSyncing` to `isProjectImportingFlow`, the latter better represents the process. These changes enhance clarity and maintainability.
The PackageSearchApiClient within the PackageSearchApplicationCachesService is updated to use the DEFAULT endpoints from PackageSearchEndpoints instead of the DEV endpoints. This change doesn't affect the behavior of the application but makes the code more consistent and easier to read.
Introduces Apache License 2.0 to the project. Modifies the README.md to include JetBrains official project badge. A new Code of Conduct file has been created, referring to the JetBrains Open Source and Community Code of Conduct. (cherry picked from commit 68a88bb)
(cherry picked from commit 461e2d7)
…esTab (#9) Refactor platformListMock to getter in HeaderAttributesTab scrollToAttribute has CoroutineScope as receiver rename InfoPanelContentEvent Attributes Declared into FromVariant and Search into FromSearch rename Attributes Declared into FromVariant and Search into FromSearch This commit adds InfoPanelContent Attributes for "Declared" type to the asPanelContent function, including the tab's title, variant's title, and attributes. A click event handler for the selected packages is also added to refresh the side panel content. A new event for package selection has been placed in 'PackageListItemEvent'. Furthermore, the attribute type name description and content title in the package search UI have been updated for clarity. The style of the 'Search' content in HeaderAttributesTab has also been modified to reduce redundancy and clarify display conditions. Now, by clicking on an attribute badge, it's possible to scroll to individual attributes with a smooth animation. (cherry picked from commit 259a0d2)
(cherry picked from commit cb159c8)
Numerous streams of data in the Kotlin coroutines flow now have the retry operator included. This optimizes error handling by implementing automated retries upon encountering failures. The modification affects key parts of the code, such as PackageListViewModel, PackageSearchProjectService, and several viewModel modules related to UI and project services. (cherry picked from commit 7e2f7a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick for
api fixes for jewel 0.12