-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend TabStrip API to support custom behaviours #276
Merged
rock3r
merged 9 commits into
main
from
275-tabs-for-tabs-strips-does-not-allow-custom-content
Dec 28, 2023
Merged
Extend TabStrip API to support custom behaviours #276
rock3r
merged 9 commits into
main
from
275-tabs-for-tabs-strips-does-not-allow-custom-content
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscarponi
changed the title
275 tabs for tabs strips does not allow custom content
Extend TabStrip API to support custom behaviours
Dec 18, 2023
fscarponi
force-pushed
the
275-tabs-for-tabs-strips-does-not-allow-custom-content
branch
2 times, most recently
from
December 19, 2023 08:40
80a6c02
to
aafc431
Compare
2 tasks
fscarponi
force-pushed
the
275-tabs-for-tabs-strips-does-not-allow-custom-content
branch
from
December 20, 2023 07:47
aafc431
to
904bb80
Compare
rock3r
force-pushed
the
275-tabs-for-tabs-strips-does-not-allow-custom-content
branch
from
December 20, 2023 17:31
6af7513
to
c28795d
Compare
rock3r
added
feature
New feature or request
consistency
Our UI presentation is not consistent with IJ
labels
Dec 20, 2023
rock3r
requested changes
Dec 20, 2023
ui/src/main/kotlin/org/jetbrains/jewel/ui/DefaultComponentStyling.kt
Outdated
Show resolved
Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/TabStrip.kt
Outdated
Show resolved
Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/TabStrip.kt
Outdated
Show resolved
Hide resolved
fscarponi
force-pushed
the
275-tabs-for-tabs-strips-does-not-allow-custom-content
branch
2 times, most recently
from
December 21, 2023 10:06
eadaeea
to
762e295
Compare
fscarponi
force-pushed
the
275-tabs-for-tabs-strips-does-not-allow-custom-content
branch
from
December 21, 2023 12:17
762e295
to
bb496b7
Compare
rock3r
requested changes
Dec 21, 2023
...les/standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/view/component/Tabs.kt
Show resolved
Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/TabStrip.kt
Outdated
Show resolved
Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/TabStrip.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastiano Poggi <[email protected]>
Co-authored-by: Sebastiano Poggi <[email protected]>
The user interface has been updated to include tab content spacing. This is established by adding a new parameter, `tabContentSpacing`, in TabMetrics and adjusting and testing its implementation across various files like `IntUiTabStyling.kt`, `IntUiBridge.kt`, and `Tabs.kt`. This modification will ensure more consistency and control over the user interface design. The user interface api file has also been updated to reflect this change.
rock3r
approved these changes
Dec 28, 2023
rock3r
deleted the
275-tabs-for-tabs-strips-does-not-allow-custom-content
branch
December 28, 2023 10:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the IDE and in some specs, you can find some kind of fanciful Tabs usage...
as an example, using a composite tabHeader content that has a title made by two different texts with different styles or icons
we can change the api for to allow users to provide content for tabs, allowing users to solve their own problems
migrating to a new DSL:
and exposing the following methods:
this will allow achieving custom behavior for the tab, as we show in the standalone sample