Support IDE zoom and presentation mode #234
Conversation
devkanro
commented
Nov 1, 2023
devkanro
commented
devkanro
requested review from
rock3r and
Walingar
and removed request for
Walingar
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeUtils.kt
Outdated
Show resolved
Hide resolved
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeUtils.kt
Outdated
Show resolved
Hide resolved
rock3r
added
bridge
|
|
||
| internal fun retrieveDensity(): Density { | ||
| val ideaScale = UISettingsUtils.getInstance().currentIdeScale | ||
| val scale = GraphicsEnvironment.getLocalGraphicsEnvironment() |
There was a problem hiding this comment.
It's better to use com.intellij.ui.scale.JBUIScale#pixScale here using Component provided as LocalComponent, and not to use defaultScreenDevice, since there are can be issues with different monitors
| CompositionLocalProvider(LocalPainterHintsProvider provides BridgePainterHintsProvider(themeData.themeDefinition.isDark)) { | ||
| CompositionLocalProvider( | ||
| LocalPainterHintsProvider provides BridgePainterHintsProvider(themeData.themeDefinition.isDark), | ||
| LocalDensity provides themeData.density, |
There was a problem hiding this comment.
Also, in the future we need to subscribe on changes in user scale, idea scale and sysScale changes
There was a problem hiding this comment.
Fwiw this already works following zoom changes; haven't checked what happens when changing screens/system scale
There was a problem hiding this comment.
Also works with presentation mode
There was a problem hiding this comment.
When ide scale changed the look and feel changing event will be fired too. I'll check the system scale event tomorrow.
|
OK, I'll check it |
