Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle IDE zoom and presentation mode #217

Closed
rock3r opened this issue Oct 30, 2023 · 2 comments · Fixed by #234
Closed

Handle IDE zoom and presentation mode #217

rock3r opened this issue Oct 30, 2023 · 2 comments · Fixed by #234
Assignees
@devkanro
Labels
bridge Something that impacts the Swing LaF bridge consistency Our UI presentation is not consistent with IJ
Milestone
Milestone 10 — v0...

Comments

@rock3r
Copy link
Collaborator

rock3r commented Oct 30, 2023

The IDE can set a global "zoom" level, starting in 23.2:

image

We need to make sure we respect that. It works for text size, but not for icons/dimensions (e.g., paddings). We probably just need to adjust the LocalDensity based on the com.intellij.ide.ui.UISettingsUtils#getCurrentIdeScale, but also need to make sure this doesn't affect the text size.

We also need to make sure we apply the correct scaling when presentation mode is active.
@rock3r rock3r added the consistency Our UI presentation is not consistent with IJ label Oct 30, 2023
@rock3r rock3r added this to the Milestone 9 — v0.9.0 milestone Oct 30, 2023
@rock3r rock3r added the bridge Something that impacts the Swing LaF bridge label Oct 31, 2023
@devkanro
Copy link
Collaborator

截屏2023-11-01 01 14 48

@devkanro
Copy link
Collaborator

截屏2023-11-01 01 15 46 Icon still need be scaled

@devkanro devkanro linked a pull request Nov 1, 2023 that will close this issue
Support IDE zoom and presentation mode #234
Merged
@lamba92 lamba92 mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devkanro devkanro

Labels
bridge Something that impacts the Swing LaF bridge consistency Our UI presentation is not consistent with IJ
Projects
None yet
Milestone
Milestone 10 — v0.10.0
Development

Successfully merging a pull request may close this issue.

Support IDE zoom and presentation mode devkanro/jewel
2 participants
@rock3r @devkanro