Introduce the bufr_query library from NOAA-EMC #461
Conversation
|
|
||
| # Optional dependencies | ||
| variant("python", default=True, description="Enable Python interface") | ||
| depends_on("python@3:", type=("build", "run"), when="+python") |
There was a problem hiding this comment.
I think that the correct syntax for Python is something like extends(python) and then use the PythonBuilder to build and install the Python interface. See https://github.com/spack/spack/pull/45504/files for how this is done. I haven't implemented a package this way myself yet, but I understand that this is how it is supposed to be.
At the minimum, please remove @3: because the minimum version that spack supports is 3.7.
There was a problem hiding this comment.
I grabbed this from another package script too. The example you give looks a lot nicer. I can take a look at that. Thanks!
There was a problem hiding this comment.
I switched the code over to use the extend("python") mechanism (as is done in the example PR you noted).
modules in the expected "lib/pythonX.Y/site-packages" directory.
|
Tested this and verified that the bufr_query install is working. This is good to go now. I solved the PYTHONPATH issue with a patch, and at the same time I've submitted a PR to bufr-query with the changes in the patch. |
|
The commit history is a bit too long for merging this as a regular merge commit (which we usually do for merges into the spack submodule for easier cherry-picking for upstream spack develop). I am going to merge this as a squash merge and we'll have to do something like |
This PR adds in a new package.py script for the new bufr_query library from NOAA-EMC. This is being used by JEDI and other applications.
|
I have created a PR in the authoritative spack repo with these changes: spack#45920 |
* Introduce the bufr_query library from NOAA-EMC (JCSDA#461) This PR adds in a new package.py script for the new bufr_query library from NOAA-EMC. This is being used by JEDI and other applications. * Add explicit build dependency spec to the pybind11 depends_on spec Co-authored-by: Wouter Deconinck <[email protected]> * Convert patch file to the URL form which pulls the changes from github. Co-authored-by: Wouter Deconinck <[email protected]> * Added new version (0.0.3) and removed obsolete site-packages.patch file --------- Co-authored-by: Wouter Deconinck <[email protected]>
This PR adds in a new package.py script for the new bufr_query library from NOAA-EMC. This is being used by JEDI and other applications.
This partially addresses JCSDA/spack-stack/issues/1182