Configuration for [email protected] and [email protected]

[srherbener]

Summary

This PR contains an initial configuration for the new bufr_query library from NOAA-EMC

Testing

• AWS Ubuntu 20.24 EC2 instance gcc (@srherbener)
  • spack-stack built successfully
  • jedi-bundle built successfully
  • all ctests passed, except for the known issue with AWS EC2 instance and some tests hanging: https://github.com/JCSDA-internal/jedi-bundle/issues/95
• Discover SCU16 intel (@srherbener)
  • spack-stack built successfully
  • Discover is down today for Milan upgrades. Since jedi-bundle built and tested okay on teh AWS instance, I'm calling it good for this test.

Applications affected

JEDI, There are likely some NOAA applications affected, but I'm not clear on which ones.

Systems affected

HPCs, MacOS

Dependencies

If there are PRs that need to be merged before or along with this one, please add "- [ ] waiting on LINK_TO_PR" for each of them

• waiting on Introduce the bufr_query library from NOAA-EMC spack#461
• waiting on Upgrade eckit to 1.27.0 spack#467

Issue(s) addressed

Resolves #1182

Checklist

• This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
• These changes have been tested on the affected systems and applications.
• All dependency PRs/issues have been resolved and this PR can be merged.

[srherbener]

My testing on the AWS instance ran into this issue: jcsda-internal/jedi-bundle/issues/95, but I also found that the bufr-query package is installing its python extension in the lib/pythonX.Y directory instead of the expected lib/pythonX.Y/site-packages directory.

What's the proper way to fix this?

• Adjust PYTHONPATH in the module file for bufr-query
• Change the bufr-query CMake configuration to install in the site-packages directory

Thanks!

[climbfuji]

My testing on the AWS instance ran into this issue: JCSDA-internal/jedi-bundle/issues/95, but I also found that the bufr-query package is installing its python extension in the lib/pythonX.Y directory instead of the expected lib/pythonX.Y/site-packages directory.

What's the proper way to fix this?

• Adjust PYTHONPATH in the module file for bufr-query
• Change the bufr-query CMake configuration to install in the site-packages directory

Thanks!

Kind of surprising, the Python extension should be handled correctly by spack (i.e. the spack modulefile should contain the correct pythonpath). Maybe it is a cmake configuration issue?

[climbfuji]

@srherbener I merged the spack PR. Feel free to push the submodule pointer update and .gitmodules reversal, but please add [skip ci] as an empty last commit so that we don't trigger CI runs. We've got a bit of a backlog of PRs to merge and CI takes a lot of time at the moment. Thanks!

[srherbener]

Sorry, I tried to do the "skip ci" but it didn't seem to take effect.

[climbfuji]

Sorry, I tried to do the "skip ci" but it didn't seem to take effect.

[skip ci] is the correct syntax

[climbfuji]

@srherbener I resolved the merge conflicts in jedi-ci.yaml, please check. I want to confirm with you that bufr_query is not supposed to be in jedi-ci.yaml (currently it isn't).

[srherbener]

@climbfuji thanks for the note about the missing bufr-query entry in the jedi-ci config. I do want that in. I noticed that this PR is out of date with develop, so I will add the bufr-query entry and merge develop.

[srherbener]

This is ready for review now. Thanks!

[srherbener]

@climbfuji thanks for all of your help with the eckit and bufr-query work. It's much appreciated!