-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate previously enacted govAction #3670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
commented
Aug 23, 2023
teodanciu
commented
Aug 23, 2023
teodanciu
commented
Aug 23, 2023
teodanciu
force-pushed
the
td/validate-prev-govid
branch
4 times, most recently
from
August 23, 2023 16:07
90035aa
to
516de6c
Compare
lehins
requested changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect with the respect to logic. Let's converge on the naming and this will be good to be merged
teodanciu
force-pushed
the
td/validate-prev-govid
branch
4 times, most recently
from
August 29, 2023 12:11
9028dfb
to
d3551ad
Compare
9 tasks
teodanciu
force-pushed
the
td/validate-prev-govid
branch
from
August 29, 2023 15:18
d3551ad
to
f95c04f
Compare
which contains `GovActionId` in addition to `GovAction`
lehins
force-pushed
the
td/validate-prev-govid
branch
from
August 30, 2023 20:46
f95c04f
to
b7b4ed9
Compare
lehins
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you!
lehins
reviewed
Aug 30, 2023
Soupstraw
pushed a commit
that referenced
this pull request
Aug 31, 2023
Validate previously enacted govAction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3656
If it doesn't match, we "drop" the signal (we don't enact it and it will eventually expire)
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)