-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal delaying, remove predicate failure from ENACT #3684
Conversation
914e168
to
7e3d316
Compare
072fc29
to
177f8a1
Compare
Oops, I just noticed @teodanciu already had an open PR implementing the delaying and |
177f8a1
to
900c2a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to go with @teodanciu's approach implemented in #3670 because it is correct, while this implementation is not quite. More importantly, however, the approach take in #3670 is much cleaner and is more flexible, because we will likely need to update prevGovActionId for PParamsUpdate during ratification. Updating the PParams during Enactment will have to happen an epoch later due to #3691. HashProtected approach in this PR prevents us from doing so.
In any case I found the HashProtected approach in the spec a bit ugly to begin with, because it is more convoluted that it has to be.
So, could you extract only the parts that are relevant for #3675 and either submit it as a new PR or modify this one, whichever you prefer.
9e1c52c
to
b86602c
Compare
3dd8d07
to
de8c3a1
Compare
c0f86ae
to
2068c60
Compare
2068c60
to
3c96350
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!!!! 💪
Love all the predicate failure cleanup
Description
Removed the predicate failure from ENACT. Made the enactment of some actions delay all the other actions. Treasury withdrawals are now delayed when there is not enough ADA in the treasury.
I also changed the logic of
RATIFY
so that actions with invalid previous governance action ID get delayed rather than dropped.closes #3675
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)