Feature/closecloud adjustments #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Axes scalable Allow SceneNode to cleanup TF, also for the child objects. Signed-off-by: Peter Soetens <[email protected]>
We're slow at drawing, if the queue fills up, it means we can't follow and need to throttle down ? Signed-off-by: Peter Soetens <[email protected]>
- zoom now 5x faster - zoom mousewheel direction as in rviz - zoom frame only shows 0.3s instead of 1s. Signed-off-by: Bert Willaert <[email protected]>
Signed-off-by: Peter Soetens <[email protected]>
trim('/') ignores its argument and only removes whitespace,
so we need to use replace(...)
Signed-off-by: Bert Willaert <[email protected]>
See https://github.com/mrdoob/three.js/wiki/Migration for some of the changes that affected us. Signed-off-by: Peter Soetens <[email protected]>
CloseCloud for higher resolution rendering of point clouds with limited depth range PointCloud for visualising PointCloud2 messages
…ud_adjustments Conflicts: build/ros3d.min.js
|
Has psoetens#1 been merged in as well ? It was actually required on the 'upgrade to three r70' feature branch such that it has a greater chance of acceptance upstream. |
No problem, that can be also merged easily. IMHO we still need to address the missing ByteBuffer dependency (91c1830) before we even have any chance of acceptance upstream. Either that or omitting the PointCloud reference type entirely? |
added 3 commits
March 10, 2016 13:58
Conflicts: src/visualization/SceneNode.js
Conflicts: build/ros3d.js build/ros3d.min.js src/visualization/SceneNode.js
- add queue_length option to PointCloud constructor arg - adjust PointCloud to read colors from PointXYZRGBNormal pointclouds Signed-off-by: Viktor Kunovski <[email protected]>
viktorku
force-pushed
the
feature/closecloud_adjustments
branch
from
5d314e2 to
a1317ca
Compare
…e tf client; avoid code duplication
viktorku
force-pushed
the
feature/closecloud_adjustments
branch
from
a1317ca to
52c8aca
Compare
added 6 commits
February 1, 2017 11:49
Conflicts: build/ros3d.min.js
Conflicts: build/ros3d.js build/ros3d.min.js src/markers/MarkerArrayClient.js src/markers/MarkerClient.js src/visualization/Viewer.js
viktorku
force-pushed
the
feature/closecloud_adjustments
branch
2 times, most recently
from
5512db0 to
b67ab96
Compare
The demos are located at http://robotwebtools.org/demos.html but the readme points the user to the homepage instead. This PR makes the link point to the actual demos page.
viktorku
force-pushed
the
feature/closecloud_adjustments
branch
from
b67ab96 to
7bb7d33
Compare
viktorku
force-pushed
the
feature/closecloud_adjustments
branch
from
47b19fc to
31106ae
Compare
added 2 commits
July 26, 2017 16:49
Conflicts: build/ros3d.js build/ros3d.min.js package.json
Conflicts: build/ros3d.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@psoetens This is great! Seems to be working by my tests.
I added some minor stuff in few commits (most important is 760fcb3).
Doesn't include the mjpeg stream changes yet.UPDATE: Merged latest version and updated CloseCloud to handle MJPEG streams.
Note: I "merged" the stopCloud method's functionality into the prototype's stopStream.