Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code base to work with modern three.js releases #158

Closed
sevenbitbyte opened this issue Jan 19, 2017 · 5 comments
Closed

Update code base to work with modern three.js releases #158

sevenbitbyte opened this issue Jan 19, 2017 · 5 comments

Comments

@sevenbitbyte
Copy link
Member

sevenbitbyte commented Jan 19, 2017

three.js is currently at version 0.84.0 but ros3d requires version 61. Attempting to use a modern threejs version results in the below warnings and errors. There are likely many more minor tweaks require beyond these:

THREE.WebGLRenderer: .shadowMapEnabled is now .shadowMap.enabled.
THREE.Projector has been moved to /examples/js/renderers/Projector.js.
THREE.ImageUtils.loadTexture has been deprecated. Use THREE.TextureLoader() instead.
THREE.ShaderMaterial: attributes should now be defined in THREE.BufferGeometry instead.
THREE.ShaderMaterial: 'attributes' is not a property of this material.
THREE.ParticleSystem has been renamed to THREE.Points.
@viktorku
Copy link
Member

Take a look at Intermodalics#1, which already bumps it up to r70 (among other things)...

@sevenbitbyte
Copy link
Member Author

@viktorku Awesome work, can't wait to leverage it. Any particular reason for targetting r70?

I've been dying to be able to fully tear down the WebGL context which is why I'm interested in moving up to r8x for better teardown support but maybe that made it into r70.

@jihoonl
Copy link
Member

jihoonl commented Dec 8, 2017

I'm trying to update the codebase to work with version 0.88.0. The basic functions are getting ready now except interactive marker and urdf. Did you have any issue with highlighting the mouseover objects when you use r70?

@jihoonl
Copy link
Member

jihoonl commented Dec 8, 2017

See #202

@jihoonl
Copy link
Member

jihoonl commented Jan 4, 2018

Resolved by #202

@jihoonl jihoonl closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants