Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AppSettingsControler and AppSettings Realm object #18

Merged
merged 8 commits into from
Aug 29, 2024
Merged

Add AppSettingsControler and AppSettings Realm object #18

merged 8 commits into from
Aug 29, 2024

Conversation

tevincent
Copy link
Contributor

No description provided.

@tevincent tevincent marked this pull request as draft August 27, 2024 06:16
@tevincent tevincent mentioned this pull request Aug 27, 2024
Merged
@tevincent tevincent marked this pull request as ready for review August 28, 2024 06:24
sirambd
sirambd requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@sirambd sirambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README and add a kDoc for all exposed method and properties

.../commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/common/models/DownloadLimit.kt Outdated Show resolved Hide resolved
...e/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/SwissTransferInjection.kt Show resolved Hide resolved
.../commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/AppSettingsManager.kt Outdated Show resolved Hide resolved
...n/com/infomaniak/multiplatform_swisstransfer/database/cache/setting/AppSettingsController.kt Outdated Show resolved Hide resolved
...n/com/infomaniak/multiplatform_swisstransfer/database/cache/setting/AppSettingsController.kt Show resolved Hide resolved
...n/com/infomaniak/multiplatform_swisstransfer/database/cache/setting/AppSettingsController.kt Show resolved Hide resolved
@tevincent tevincent requested a review from sirambd August 28, 2024 15:28
sirambd
sirambd requested changes Aug 29, 2024
View reviewed changes
...mmon/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/common/models/Theme.kt Outdated Show resolved Hide resolved
...commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/common/models/ValidityPeriod.kt Outdated Show resolved Hide resolved
STCore/README.md Show resolved Hide resolved
STCore/README.md Outdated Show resolved Hide resolved
...e/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/SwissTransferInjection.kt Outdated Show resolved Hide resolved
...n/com/infomaniak/multiplatform_swisstransfer/database/cache/setting/AppSettingsController.kt Outdated Show resolved Hide resolved
...n/kotlin/com/infomaniak/multiplatform_swisstransfer/database/models/setting/AppSettingsDB.kt Outdated Show resolved Hide resolved
...n/kotlin/com/infomaniak/multiplatform_swisstransfer/database/models/setting/AppSettingsDB.kt Outdated Show resolved Hide resolved
...n/kotlin/com/infomaniak/multiplatform_swisstransfer/database/models/setting/AppSettingsDB.kt Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sirambd sirambd merged commit cbbcde8 into master Aug 29, 2024
4 checks passed
@sirambd sirambd deleted the implement-app-settings-realm branch August 29, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirambd sirambd sirambd approved these changes

Assignees

@tevincent tevincent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tevincent @sirambd