Add Theme, ValidityPeriod, DownloadLimit & EmailLanguage settings #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevincent
force-pushed
the
settings-realm
branch
from
f934ac6
to
3801e50
Compare
tevincent
force-pushed
the
settings-realm
branch
2 times, most recently
from
b968603
to
aa85023
Compare
tevincent
force-pushed
the
settings-realm
branch
from
5a05c3b
to
686713a
Compare
sirambd
requested changes
Aug 30, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/MainActivity.kt
Outdated
Show resolved
Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDownloadsLimitScreen.kt
Outdated
Show resolved
Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDownloadsLimitScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreenWrapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsThemeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsThemeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
tevincent
force-pushed
the
settings-realm
branch
5 times, most recently
from
c81cdcd
to
9ecad63
Compare
sirambd
requested changes
Aug 30, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/MainApplication.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
|
We have an issue on jitpack. I've opened a ticket: With this error: It's not building because 0.1.1 is not available on jitpack. |
KevinBoulongne
requested changes
Sep 2, 2024
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDownloadsLimitScreen.kt
Outdated
Show resolved
Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDownloadsLimitScreen.kt
Outdated
Show resolved
Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDownloadsLimitScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsThemeScreen.kt
Outdated
Show resolved
Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsValidityPeriodScreen.kt
Outdated
Show resolved
Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsValidityPeriodScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/di/ApplicationModule.kt
Outdated
Show resolved
Hide resolved
That's it, I've solved it by rebuilding the build, and I've also updated the issue to see if they can give us any advice on how to prevent it from happening again. |
KevinBoulongne
force-pushed
the
settings-realm
branch
from
c7d56db
to
434d8c6
Compare
KevinBoulongne
force-pushed
the
settings-realm
branch
2 times, most recently
from
1232f7e
to
c775506
Compare
KevinBoulongne
requested changes
Sep 3, 2024
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDownloadsLimitScreen.kt
Show resolved
Hide resolved
KevinBoulongne
force-pushed
the
settings-realm
branch
from
c775506
to
d753b10
Compare
KevinBoulongne
changed the title
|
This PR/issue depends on: |
1 similar comment
|
This PR/issue depends on: |
…settings/SettingsDownloadsLimitScreen.kt Co-authored-by: Kevin Boulongne <[email protected]>
…settings/SettingsValidityPeriodScreen.kt Co-authored-by: Kevin Boulongne <[email protected]>
…settings/SettingsValidityPeriodScreen.kt Co-authored-by: Kevin Boulongne <[email protected]>
KevinBoulongne
force-pushed
the
settings-realm
branch
from
fae2b1d
to
7aebfde
Compare
|
KevinBoulongne
approved these changes
Sep 4, 2024
sirambd
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Infomaniak/multiplatform-SwissTransfer#18
Depends on #42