Use the new networkstatus flow to know if we have internet or not #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
requested changes
Jul 18, 2024
...src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
Show resolved
Hide resolved
...src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
Outdated
Show resolved
Hide resolved
tevincent
force-pushed
the
use-network-status-flow
branch
2 times, most recently
from
78f6c2d
to
1c40c2f
Compare
KevinBoulongne
previously approved these changes
Jul 22, 2024
tevincent
force-pushed
the
use-network-status-flow
branch
2 times, most recently
from
7ce2d72
to
45b0df3
Compare
FabianDevel
previously approved these changes
Jul 24, 2024
tevincent
force-pushed
the
use-network-status-flow
branch
2 times, most recently
from
3d069ca
to
aaa44e6
Compare
|
This PR/issue depends on: |
Merged
tevincent
force-pushed
the
use-network-status-flow
branch
2 times, most recently
from
090e04e
to
d2058e6
Compare
tevincent
dismissed stale reviews from FabianDevel and KevinBoulongne
Waiting for siram
tevincent
force-pushed
the
use-network-status-flow
branch
5 times, most recently
from
3d066c4
to
ca3579f
Compare
tevincent
force-pushed
the
use-network-status-flow
branch
from
ca3579f
to
ce06e89
Compare
KevinBoulongne
requested changes
Aug 13, 2024
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
Outdated
Show resolved
Hide resolved
sirambd
requested changes
Aug 13, 2024
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt
Show resolved
Hide resolved
...src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
Outdated
Show resolved
Hide resolved
sirambd
approved these changes
Aug 13, 2024
KevinBoulongne
requested changes
Aug 13, 2024
...src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
Outdated
Show resolved
Hide resolved
tevincent
force-pushed
the
use-network-status-flow
branch
from
7b78a6c
to
59b812b
Compare
KevinBoulongne
requested changes
Aug 13, 2024
...src/main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
approved these changes
Aug 13, 2024
tevincent
requested review from
FabianDevel
and removed request for
FabianDevel
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on Infomaniak/android-core#208
no_network_flow_empty_attachment.mp4