Code review

Infomaniak · Aug 13, 2024 · 7b78a6c · 7b78a6c
1 parent 5cbdb5a
commit 7b78a6c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt b/app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt
@@ -179,7 +179,7 @@ class MainViewModel @Inject constructor(
         .stateIn(
             scope = viewModelScope,
             started = SharingStarted.Eagerly,
-            initialValue = null
+            initialValue = null,
         )
 
     private var currentThreadsLiveJob: Job? = null

diff --git a/.../main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt b/.../main/java/com/infomaniak/mail/ui/main/thread/actions/DownloadAttachmentProgressDialog.kt
@@ -79,8 +79,6 @@ class DownloadAttachmentProgressDialog : DialogFragment() {
     }
 
     private fun popBackStackWithError() {
-        // We have to use the Flow instead of the LiveData here since the mainViewModel is not the same instance as the one in the
-        // MainActivity. So, instead of observing the LiveData in order to make it "active", we use the Flow.
         viewLifecycleOwner.lifecycleScope.launch {
             mainViewModel.isNetworkAvailable.first { it != null }?.let { isNetworkAvailable ->
                 val title = if (isNetworkAvailable) R.string.anErrorHasOccurred else R.string.noConnection