Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests about custom FormatterFileSize #175

Merged
merged 8 commits into from
May 15, 2024
Merged

Unit tests about custom FormatterFileSize #175

merged 8 commits into from
May 15, 2024

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented May 8, 2024 •
edited
Loading

Depends on #173

Adds unit tests about our custom FormatterFileSize, to check if the data is correctly rounded when it should be, and not rounded when it shouldn't.
It also checks if the data is correctly formatted using 1_024 base, and not 1_000 base.

@KevinBoulongne KevinBoulongne added the feature A new functionality is added to the product label May 8, 2024
@KevinBoulongne KevinBoulongne changed the title Size formatter tests Custom FormatterFileSize tests May 8, 2024
This was referenced May 8, 2024
Merged
Merged
@KevinBoulongne KevinBoulongne changed the title Custom FormatterFileSize tests Unit tests about custom FormatterFileSize May 8, 2024
@KevinBoulongne KevinBoulongne force-pushed the human-readable-binary-bytes-count branch from eb977bf to 8f4688f Compare May 8, 2024 12:08
@KevinBoulongne KevinBoulongne force-pushed the human-readable-binary-bytes-count branch from fb7f0dd to 3e7f3f0 Compare May 8, 2024 13:52
@KevinBoulongne KevinBoulongne force-pushed the size-formatter-tests branch 2 times, most recently from bdfec42 to 99000e2 Compare May 8, 2024 14:33
@tevincent
Copy link
Contributor

We also need to add an android.yml file to run the test on the CI right?

@KevinBoulongne KevinBoulongne force-pushed the human-readable-binary-bytes-count branch from b93d194 to 806e291 Compare May 13, 2024 06:15
@KevinBoulongne KevinBoulongne force-pushed the size-formatter-tests branch 3 times, most recently from 563450e to 665f87b Compare May 13, 2024 06:35
@KevinBoulongne KevinBoulongne force-pushed the human-readable-binary-bytes-count branch from 95a54fe to 0e97dfc Compare May 14, 2024 07:01
Base automatically changed from human-readable-binary-bytes-count to master May 14, 2024 07:03
@KevinBoulongne KevinBoulongne mentioned this pull request May 15, 2024
Closed
@KevinBoulongne KevinBoulongne changed the base branch from master to tests-on-CI May 15, 2024 05:57
@KevinBoulongne KevinBoulongne changed the base branch from tests-on-CI to master May 15, 2024 08:34
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tevincent tevincent merged commit fe0ca6b into master May 15, 2024
6 of 7 checks passed
@tevincent tevincent deleted the size-formatter-tests branch May 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX Awaiting requested review from LunarX

@tevincent tevincent Awaiting requested review from tevincent

Assignees

@KevinBoulongne KevinBoulongne

Labels
feature A new functionality is added to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBoulongne @tevincent @LunarX