Put back custom FormatterFileSize to use binary format (1024) instead of SI one (1000) #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
force-pushed
the
human-readable-binary-bytes-count
branch
from
9fffc7a
to
ba36c73
Compare
KevinBoulongne
changed the title
Formatter.formatShortFileSize to use binary format (1024) instead of SI one (1000)
KevinBoulongne
force-pushed
the
human-readable-binary-bytes-count
branch
2 times, most recently
from
dd71d4c
to
bba27b8
Compare
KevinBoulongne
force-pushed
the
human-readable-binary-bytes-count
branch
4 times, most recently
from
eded749
to
cc72f9a
Compare
JorisBodin
requested changes
May 8, 2024
KevinBoulongne
force-pushed
the
human-readable-binary-bytes-count
branch
from
eb977bf
to
8f4688f
Compare
KevinBoulongne
force-pushed
the
human-readable-binary-bytes-count
branch
2 times, most recently
from
b93d194
to
806e291
Compare
…) instead of SI one (1000)
This reverts commit cf0eb50.
KevinBoulongne
force-pushed
the
human-readable-binary-bytes-count
branch
from
95a54fe
to
0e97dfc
Compare
|
tevincent
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Android O, Google decided to use SI format (1000) instead of binary one (1024) to display bytes.
Source : https://stackoverflow.com/a/3758880
Unit tests are here : #175