bug: Make Shapes private and use them from CustomShapes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
requested review from
a team and
LunarX
and removed request for
a team
KevinBoulongne
force-pushed
the
custom-shapes
branch
from
c038f00 to
9d95efb
Compare
KevinBoulongne
force-pushed
the
settings-data-images
branch
from
f25c9f1 to
6cfa026
Compare
KevinBoulongne
force-pushed
the
custom-shapes
branch
from
9d95efb to
f9595f9
Compare
This was referenced Oct 16, 2024
KevinBoulongne
force-pushed
the
settings-data-images
branch
from
6cfa026 to
8bfccd5
Compare
KevinBoulongne
force-pushed
the
custom-shapes
branch
from
f9595f9 to
a31c28b
Compare
|
This PR/issue depends on:
|
KevinBoulongne
force-pushed
the
custom-shapes
branch
from
a31c28b to
4c2be8d
Compare
|
tevincent
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #92