Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add UploadSuccess screens #96

Merged
merged 27 commits into from
Oct 24, 2024
Merged

feat: Add UploadSuccess screens #96

merged 27 commits into from
Oct 24, 2024

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Oct 16, 2024 •
edited
Loading

Depends on #102

@KevinBoulongne KevinBoulongne requested a review from a team October 16, 2024 09:42
@KevinBoulongne KevinBoulongne mentioned this pull request Oct 17, 2024
Merged
@KevinBoulongne KevinBoulongne changed the base branch from custom-shapes to upload-success-strings October 17, 2024 07:38
@KevinBoulongne KevinBoulongne force-pushed the upload-success branch 2 times, most recently from 156ce8d to 75de684 Compare October 17, 2024 07:55
Base automatically changed from upload-success-strings to main October 17, 2024 09:47
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@KevinBoulongne KevinBoulongne force-pushed the upload-success branch 3 times, most recently from b6ba362 to ea9413a Compare October 17, 2024 11:47
LunarX
LunarX requested changes Oct 17, 2024
View reviewed changes
app/src/main/java/com/infomaniak/swisstransfer/ui/components/EmailAddressChip.kt Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/QrCode.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/navigation/NavigationDestination.kt Outdated Show resolved Hide resolved
...n/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessEmailScreen.kt Show resolved Hide resolved
...n/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessEmailScreen.kt Outdated Show resolved Hide resolved
...n/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessEmailScreen.kt Outdated Show resolved Hide resolved
...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessQrScreen.kt Outdated Show resolved Hide resolved
...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessQrScreen.kt Outdated Show resolved Hide resolved
...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessQrScreen.kt Outdated Show resolved Hide resolved
...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessQrScreen.kt Outdated Show resolved Hide resolved
@KevinBoulongne KevinBoulongne force-pushed the upload-success branch 3 times, most recently from 4a9f077 to 8d4c942 Compare October 18, 2024 10:16
@KevinBoulongne KevinBoulongne requested a review from LunarX October 18, 2024 11:11
@KevinBoulongne
feat: Add IllustratedMessageBlock
09c0e4b
@KevinBoulongne
chore: Display empty state in Received screen
e2e82b2
@KevinBoulongne
feat: Use IllustratedMessageBlock to display content in UploadSuccess…
ccbc533 
…Email screen
@KevinBoulongne
review: Use Spacers instead of modifying padding
3959067
@KevinBoulongne
review: Make content scrollable if the device screen it too small
5917b33
@KevinBoulongne
review: Add sides margin to IllustratedMessageBlock
e5b7880
@KevinBoulongne
chore: Remove now useless testing code
5b880ba
@KevinBoulongne
refactor: Extract Screens content into functions
3c9327b
@KevinBoulongne
fix: Handle new names of CustomShapes
edaed19
@KevinBoulongne
review: Use margin horizontal instead of start + end
75da366
@KevinBoulongne
refactor: Use a SuggestionChip for the EmailAddressChip instead of cr…
7c88bc7 
…eating it from scratch
@KevinBoulongne
review: Remove padding from IllustratedMessageBlock
adc26c3
@KevinBoulongne
review: Use SuggestionChipDefaults.suggestionChipColors() to set Ch…
f14ae33 
…ips colors
@KevinBoulongne
fix: Rename wrongly names Previews
8b64e05
@KevinBoulongne
refactor: Move hardcoded email string to an upper level
1c48537
@KevinBoulongne
review: Move vertical arrangement from IllustratedMessageBlock to Emp…
523fca4 
…tyState
@KevinBoulongne
feat: Add Copy & Share icons in UploadSuccessQr screen
22e579c
@KevinBoulongne
feat: Use a FlowRow to display a list of emails instead of a single o…
9d976a4 
…ne in UploadSuccessEmail screen
@KevinBoulongne
review: Rename + clean some icons
f2386ff
@KevinBoulongne
review: Move padding to Column
031589e
@KevinBoulongne KevinBoulongne requested a review from LunarX October 24, 2024 04:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit a7fb1e3 into main Oct 24, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the upload-success branch October 24, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tevincent tevincent tevincent approved these changes

@LunarX LunarX LunarX approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBoulongne @LunarX @tevincent