Use a PreviewParameter to factorize FileUiItem instantiation inside previews #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
2 times, most recently
from
21dc3d5 to
7a7d936
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
7a7d936 to
c24eb13
Compare
LunarX
force-pushed
the
display-picked-files
branch
from
aa3e3b2 to
f2f6fae
Compare
KevinBoulongne
approved these changes
Oct 17, 2024
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
2 times, most recently
from
3f4065c to
5de64c7
Compare
sirambd
requested changes
Oct 17, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SmallFileTile.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
display-picked-files
branch
from
3619793 to
da57824
Compare
|
This PR/issue depends on:
|
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
5de64c7 to
f9bafbe
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
f9bafbe to
abde5b9
Compare
|
sirambd
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was always using the same list of FileUiItems so instead of copy pasting it everywhere, I used the PreviewParameter that serves this very purpose
Depends on #87