-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn FileUiItem from interface to data class to make future replacement easier #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
October 15, 2024 07:53
446c9cf
to
21dc3d5
Compare
LunarX
force-pushed
the
file-ui-interface-to-data-class
branch
2 times, most recently
from
October 16, 2024 06:24
f81ee26
to
9becbc6
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
October 16, 2024 06:24
21dc3d5
to
7a7d936
Compare
LunarX
force-pushed
the
file-ui-interface-to-data-class
branch
from
October 16, 2024 08:23
9becbc6
to
34c9ae8
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
October 16, 2024 08:23
7a7d936
to
c24eb13
Compare
KevinBoulongne
requested changes
Oct 17, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
file-ui-interface-to-data-class
branch
from
October 17, 2024 10:43
34c9ae8
to
c8af9df
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
October 17, 2024 10:43
c24eb13
to
3f4065c
Compare
LunarX
force-pushed
the
file-ui-interface-to-data-class
branch
from
October 17, 2024 10:48
c8af9df
to
193988a
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
October 17, 2024 10:48
3f4065c
to
5de64c7
Compare
sirambd
approved these changes
Oct 17, 2024
LunarX
force-pushed
the
file-ui-interface-to-data-class
branch
from
October 18, 2024 08:32
193988a
to
e19183e
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
October 18, 2024 08:32
5de64c7
to
f9bafbe
Compare
LunarX
force-pushed
the
file-ui-interface-to-data-class
branch
from
October 18, 2024 08:33
e19183e
to
a6bba68
Compare
LunarX
force-pushed
the
provide-file-ui-item-preview
branch
from
October 18, 2024 08:33
f9bafbe
to
abde5b9
Compare
KevinBoulongne
approved these changes
Oct 18, 2024
This PR/issue depends on: |
LunarX
force-pushed
the
file-ui-interface-to-data-class
branch
from
October 18, 2024 09:02
a6bba68
to
708e339
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only turns FileUiItem from an interface into a data class and renames it into FileUi
Depends on #88