Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn FileUiItem from interface to data class to make future replacement easier #89

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Oct 14, 2024

This only turns FileUiItem from an interface into a data class and renames it into FileUi

Depends on #88

@LunarX LunarX added the quick A pull request consisting of a few lines label Oct 14, 2024
@LunarX LunarX requested review from sirambd and a team October 14, 2024 07:14
@LunarX LunarX self-assigned this Oct 14, 2024
@LunarX LunarX force-pushed the provide-file-ui-item-preview branch from 446c9cf to 21dc3d5 Compare October 15, 2024 07:53
@LunarX LunarX force-pushed the file-ui-interface-to-data-class branch 2 times, most recently from f81ee26 to 9becbc6 Compare October 16, 2024 06:24
@LunarX LunarX force-pushed the provide-file-ui-item-preview branch from 21dc3d5 to 7a7d936 Compare October 16, 2024 06:24
@LunarX LunarX force-pushed the file-ui-interface-to-data-class branch from 9becbc6 to 34c9ae8 Compare October 16, 2024 08:23
@LunarX LunarX force-pushed the provide-file-ui-item-preview branch from 7a7d936 to c24eb13 Compare October 16, 2024 08:23
@LunarX LunarX force-pushed the file-ui-interface-to-data-class branch from 34c9ae8 to c8af9df Compare October 17, 2024 10:43
@LunarX LunarX force-pushed the provide-file-ui-item-preview branch from c24eb13 to 3f4065c Compare October 17, 2024 10:43
@LunarX LunarX force-pushed the file-ui-interface-to-data-class branch from c8af9df to 193988a Compare October 17, 2024 10:48
@LunarX LunarX force-pushed the provide-file-ui-item-preview branch from 3f4065c to 5de64c7 Compare October 17, 2024 10:48
@LunarX LunarX force-pushed the file-ui-interface-to-data-class branch from 193988a to e19183e Compare October 18, 2024 08:32
@LunarX LunarX force-pushed the provide-file-ui-item-preview branch from 5de64c7 to f9bafbe Compare October 18, 2024 08:32
@LunarX LunarX force-pushed the file-ui-interface-to-data-class branch from e19183e to a6bba68 Compare October 18, 2024 08:33
@LunarX LunarX force-pushed the provide-file-ui-item-preview branch from f9bafbe to abde5b9 Compare October 18, 2024 08:33
@LunarX LunarX requested a review from KevinBoulongne October 18, 2024 08:36
Base automatically changed from provide-file-ui-item-preview to main October 18, 2024 08:43
Copy link

This PR/issue depends on:

@LunarX LunarX force-pushed the file-ui-interface-to-data-class branch from a6bba68 to 708e339 Compare October 18, 2024 09:02
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
43.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@LunarX LunarX merged commit 8f390b5 into main Oct 18, 2024
3 of 4 checks passed
@LunarX LunarX deleted the file-ui-interface-to-data-class branch October 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick A pull request consisting of a few lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants