Adds and use the component to display picked files during a new transfer #87

LunarX · 2024-10-14T06:25:14Z

For now it displays picked files without copying them to the app's local storage. This will come in a second PR

Depends on #85

github-actions · 2024-10-16T08:08:40Z

This PR/issue depends on:

~~Create a FileTileList component #85~~
By Dependent Issues (🤖). Happy coding!

…sitions

Thanks to this the newly added files are visible and you can see them being added, else they're hidden outside the screen and you don't see any movement

...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt

...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt

app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferCard.kt

app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt

app/src/main/java/com/infomaniak/swisstransfer/ui/components/CrossCircleButton.kt

app/src/main/res/values-fr/strings.xml

Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]> Update app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt Co-authored-by: Kevin Boulongne <[email protected]>

# Conflicts: # app/build.gradle.kts # app/src/main/java/com/infomaniak/swisstransfer/ui/components/Buttons.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt

app/build.gradle.kts

app/src/main/java/com/infomaniak/swisstransfer/ui/components/FilePreview.kt

...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt

...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt

...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/SelectedFilesCard.kt

sirambd · 2024-10-17T14:49:21Z

Fix Sonar issues

app/src/main/res/values-fr/strings.xml

# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/components/Buttons.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt

sonarqubecloud · 2024-10-18T07:42:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

LunarX added the enhancement New feature or request label Oct 14, 2024

LunarX requested a review from sirambd October 14, 2024 06:25

LunarX self-assigned this Oct 14, 2024

github-actions bot added the dependent label Oct 16, 2024

LunarX mentioned this pull request Oct 16, 2024

Use a PreviewParameter to factorize FileUiItem instantiation inside previews #88

Merged

Base automatically changed from image-tile-list-component to main October 16, 2024 08:08

github-actions bot removed the dependent label Oct 16, 2024

LunarX added 14 commits October 16, 2024 10:14

List amount of selected files and add button

ac2a71a

Display the list of picked files using SmallFileTile

5436a1a

Factorize file preview logic between FileTile and SmallFileTile

4f88a82

Remove old TransferFile names from methods and variables

7387299

Remove imported files when clicking the remove button and animate it all

255b4f0

Use correct strings for the files to transfers

ed9de91

Find a way to detect the quantity of left file size for plural string

3be3c11

Clean code

0cec152

Optimize recomposition of space left plural string

733ddaa

Use a lambda for enabled in swiss transfer buttons to avoid recompo…

f04a015

…sitions

Extract composables into a SelectedFilesCard for readability

0c826bc

Extract SelectedFilesCard to its own component

325ba35

Put last imported as the first items in the SelectedFilesCard

f0d95c1

Thanks to this the newly added files are visible and you can see them being added, else they're hidden outside the screen and you don't see any movement

Fix padding around SelectedFilesCard

f2f6fae

LunarX force-pushed the display-picked-files branch from aa3e3b2 to f2f6fae Compare October 16, 2024 08:23

KevinBoulongne requested changes Oct 17, 2024

View reviewed changes

tevincent reviewed Oct 17, 2024

View reviewed changes

app/src/main/res/values-fr/strings.xml Show resolved Hide resolved

LunarX force-pushed the display-picked-files branch from d4440e8 to 776a4c9 Compare October 17, 2024 10:35

LunarX added 2 commits October 17, 2024 12:38

Merge remote-tracking branch 'origin/main' into display-picked-files

6c5ba5c

# Conflicts: # app/build.gradle.kts # app/src/main/java/com/infomaniak/swisstransfer/ui/components/Buttons.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt

Merge remote-tracking branch 'origin/main' into display-picked-files

874b204

sirambd requested changes Oct 17, 2024

View reviewed changes

KevinBoulongne requested changes Oct 18, 2024

View reviewed changes

app/src/main/res/values-fr/strings.xml Show resolved Hide resolved

LunarX force-pushed the display-picked-files branch 2 times, most recently from eea7fcc to 8262a8f Compare October 18, 2024 07:36

LunarX added 12 commits October 18, 2024 09:41

Fix merge conflict

296171a

Add "many" plural form to picked file translations

9fedb8f

Rewrite kotlin parcelize import using kotlin() helper

f201d1f

Move SelectedFilesCard to the component package

28b25b4

Better name "human readable size" related variables

910f2c7

Extract some human readable size operations to its own utils file

b413948

Remove wrong usage of derivedStateOf

dba4637

Rename SelectedFilesCard into ImportedFilesCard

d718566

Better write CrossCircleButton

2fd4cca

Rename SmallFileTile into SmallFileItem

740d3b9

Optimize ImportedFilesCard

7e64047

Replace [0] accessor with .first()

da57824

LunarX force-pushed the display-picked-files branch from 3619793 to da57824 Compare October 18, 2024 07:42

LunarX requested review from KevinBoulongne and sirambd October 18, 2024 07:42

sirambd approved these changes Oct 18, 2024

View reviewed changes

tevincent approved these changes Oct 18, 2024

View reviewed changes

KevinBoulongne approved these changes Oct 18, 2024

View reviewed changes

LunarX merged commit 626df63 into main Oct 18, 2024
4 checks passed

LunarX deleted the display-picked-files branch October 18, 2024 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds and use the component to display picked files during a new transfer #87

Adds and use the component to display picked files during a new transfer #87

LunarX commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024

sirambd commented Oct 17, 2024

sonarqubecloud bot commented Oct 18, 2024

Adds and use the component to display picked files during a new transfer #87

Adds and use the component to display picked files during a new transfer #87

Conversation

LunarX commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 16, 2024

sirambd commented Oct 17, 2024

sonarqubecloud bot commented Oct 18, 2024

Quality Gate passed

LunarX commented Oct 14, 2024 •

edited

Loading