Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implementing "Edit" & "Retry" features #282

Merged
merged 5 commits into from
Dec 24, 2024
Merged

feat: Implementing "Edit" & "Retry" features #282

merged 5 commits into from
Dec 24, 2024

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Dec 20, 2024 •
edited
Loading

No description provided.

@KevinBoulongne KevinBoulongne changed the title feat: Implementing the "Retry" feature feat: Implementing the "Retry transfer" feature Dec 20, 2024
@KevinBoulongne KevinBoulongne requested a review from a team December 20, 2024 12:35
@KevinBoulongne KevinBoulongne changed the base branch from retry-transfer to main December 24, 2024 09:13
@KevinBoulongne KevinBoulongne changed the title feat: Implementing the "Retry transfer" feature feat: Implementing "Edit" & "Retry" features Dec 24, 2024
@KevinBoulongne KevinBoulongne force-pushed the retry-same-transfer branch 5 times, most recently from 2f61874 to 4417fa8 Compare December 24, 2024 12:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

LouisCAD
LouisCAD approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@LouisCAD LouisCAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added 2 comments on something we can improve in this PR, or later on.

...in/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadProgressViewModel.kt Show resolved Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadProgressViewModel.kt Show resolved Hide resolved
@KevinBoulongne KevinBoulongne merged commit 70a62d4 into main Dec 24, 2024
6 checks passed
@KevinBoulongne KevinBoulongne deleted the retry-same-transfer branch December 24, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisCAD LouisCAD LouisCAD approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBoulongne @LouisCAD