feat: When retrying the uploading transfer, we keep transfer data whe…

…n going back to ImportFiles instead of resetting it
Infomaniak · Dec 20, 2024 · 4ffd5a8 · 4ffd5a8
1 parent f3a74d3
commit 4ffd5a8
Show file tree

Hide file tree

Showing 9 changed files with 39 additions and 10 deletions.
diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt
@@ -65,7 +65,10 @@ fun NewTransferNavHost(navController: NavHostController, closeActivity: () -> Un
             )
         }
         composable<UploadErrorDestination> {
-            UploadErrorScreen(navigateToImportFiles = { navController.navigate(ImportFilesDestination) })
+            UploadErrorScreen(
+                retryTransfer = { /* TODO */ },
+                navigateBackToImportFiles = { navController.popBackStack(route = ImportFilesDestination, inclusive = false) },
+            )
         }
     }
 }
diff --git a/.../main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadErrorScreen.kt b/.../main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadErrorScreen.kt
@@ -21,25 +21,30 @@ import androidx.compose.material3.Surface
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.res.stringResource
 import com.infomaniak.swisstransfer.R
-import com.infomaniak.swisstransfer.ui.components.BottomStickyButtonScaffold
-import com.infomaniak.swisstransfer.ui.components.BrandTopAppBar
-import com.infomaniak.swisstransfer.ui.components.EmptyState
-import com.infomaniak.swisstransfer.ui.components.LargeButton
+import com.infomaniak.swisstransfer.ui.components.*
 import com.infomaniak.swisstransfer.ui.images.AppImages.AppIllus
 import com.infomaniak.swisstransfer.ui.images.illus.uploadError.GhostMagnifyingGlassQuestionMark
 import com.infomaniak.swisstransfer.ui.theme.SwissTransferTheme
 import com.infomaniak.swisstransfer.ui.utils.PreviewAllWindows
 import com.infomaniak.core2.R as RCore2
 
 @Composable
-fun UploadErrorScreen(navigateToImportFiles: () -> Unit) {
+fun UploadErrorScreen(retryTransfer: () -> Unit, navigateBackToImportFiles: () -> Unit) {
     BottomStickyButtonScaffold(
         topBar = { BrandTopAppBar() },
-        bottomButton = {
+        topButton = {
             LargeButton(
                 modifier = it,
                 title = stringResource(RCore2.string.buttonRetry),
-                onClick = navigateToImportFiles,
+                onClick = retryTransfer,
+            )
+        },
+        bottomButton = {
+            LargeButton(
+                modifier = it,
+                title = stringResource(R.string.buttonEditTransfer),
+                style = ButtonType.SECONDARY,
+                onClick = navigateBackToImportFiles,
             )
         }
     ) {
@@ -56,7 +61,7 @@ fun UploadErrorScreen(navigateToImportFiles: () -> Unit) {
 private fun UploadErrorScreenPreview() {
     SwissTransferTheme {
         Surface {
-            UploadErrorScreen({})
+            UploadErrorScreen({}, {})
         }
     }
 }
diff --git a/...in/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadProgressScreen.kt b/...in/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadProgressScreen.kt
@@ -66,7 +66,19 @@ fun UploadProgressScreen(
         uploadProgressViewModel.trackUploadProgress()
     }
 
-    HandleProgressState({ uiState }, navigateToUploadSuccess, navigateToUploadError, navigateBackToImportFiles)
+    HandleProgressState(
+        uiState = { uiState },
+        navigateToUploadSuccess = navigateToUploadSuccess,
+        navigateToUploadError = {
+            // If the transfer fails, we need to remove the upload session
+            // before going back to ImportFilesScreen to edit the transfer.
+            // TODO: This is possibly only mandatory for editing the transfer, and not retrying it.
+            //  This needs to be checked when implementing the "Retry" feature.
+            uploadProgressViewModel.removeAllUploadSession()
+            navigateToUploadError()
+        },
+        navigateBackToImportFiles = navigateBackToImportFiles,
+    )
 
     UploadProgressScreen(
         progressState = { uiState },

diff --git a/...java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadProgressViewModel.kt b/...java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadProgressViewModel.kt
@@ -91,6 +91,10 @@ class UploadProgressViewModel @Inject constructor(
         }
     }
 
+    fun removeAllUploadSession() {
+        viewModelScope.launch(ioDispatcher) { uploadManager.removeAllUploadSession() }
+    }
+
     companion object {
         private val TAG = UploadProgressViewModel::class.java.simpleName
     }

diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml
@@ -22,6 +22,7 @@
     <string name="buttonCopyLink">Link kopieren</string>
     <string name="buttonDownload">Download</string>
     <string name="buttonDownloadSelected">Auswahl herunterladen</string>
+    <string name="buttonEditTransfer">Meine Übertragung bearbeiten</string>
     <string name="buttonFinished">Beenden</string>
     <string name="buttonShare">Teilen</string>
     <string name="buttonStart">Starten</string>

diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml
@@ -22,6 +22,7 @@
     <string name="buttonCopyLink">Copiar enlace</string>
     <string name="buttonDownload">Descargar</string>
     <string name="buttonDownloadSelected">Descargar la selección</string>
+    <string name="buttonEditTransfer">Editar mi transferencia</string>
     <string name="buttonFinished">Acabado</string>
     <string name="buttonShare">Compartir</string>
     <string name="buttonStart">Inicio</string>

diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml
@@ -22,6 +22,7 @@
     <string name="buttonCopyLink">Copier le lien</string>
     <string name="buttonDownload">Télécharger</string>
     <string name="buttonDownloadSelected">Télécharger la sélection</string>
+    <string name="buttonEditTransfer">Modifier mon transfert</string>
     <string name="buttonFinished">Terminer</string>
     <string name="buttonShare">Partager</string>
     <string name="buttonStart">Démarrer</string>

diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml
@@ -22,6 +22,7 @@
     <string name="buttonCopyLink">Copia link</string>
     <string name="buttonDownload">Scaricare</string>
     <string name="buttonDownloadSelected">Scarica la selezione</string>
+    <string name="buttonEditTransfer">Modifica mio trasferimento</string>
     <string name="buttonFinished">Finisci</string>
     <string name="buttonShare">Condividi</string>
     <string name="buttonStart">Inizio</string>

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -26,6 +26,7 @@
     <string name="buttonCopyLink">Copy link</string>
     <string name="buttonDownload">Download</string>
     <string name="buttonDownloadSelected">Download selection</string>
+    <string name="buttonEditTransfer">Edit my transfer</string>
     <string name="buttonFinished">Finish</string>
     <string name="buttonShare">Share</string>
     <string name="buttonStart">Start</string>