-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show number of defined columns as rowChangesCount for new row with batch editing #12234
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ed7c7df
feat(grid): show correct number of changes for new row
MonikaKirkova 17effa9
Merge branch 'master' into mkirkova/feat-12212
teodosiah 66a90e3
chore(grid): add feature to CHANGELOG
MonikaKirkova f6106e3
Merge branch 'master' into mkirkova/feat-12212
MonikaKirkova 5196280
Merge branch 'master' into mkirkova/feat-12212
teodosiah 3790ab5
refactor(grid): use private property
MonikaKirkova 69c574e
Merge branch 'master' into mkirkova/feat-12212
teodosiah 2141947
Merge branch 'master' into mkirkova/feat-12212
teodosiah 72ffb0b
Merge branch 'master' into mkirkova/feat-12212
teodosiah b239e66
Merge branch 'master' into mkirkova/feat-12212
teodosiah 1d3cf29
Merge branch 'master' into mkirkova/feat-12212
teodosiah 764326a
Merge branch 'master' into mkirkova/feat-12212
kdinev 72514ef
Merge branch 'master' into mkirkova/feat-12212
teodosiah ebfa4f6
Merge branch 'master' into mkirkova/feat-12212
kdinev 3734b76
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
MonikaKirkova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there columns without a field and why are they excluded from the count?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field property of the unbound columns is undefined and there was a meeting where we discussed to include only the defined columns which are included in the data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonikaKirkova OK, makes sense. However, I'm not finding anything in the docs about
unbound column
. I didn't know we support this, nor can I find that it's done without specifying a field property value. @ChronosSF This last part of the comment should be addressed. It's not directed at Monika specifically :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By unbound column I mean a column, which field property is not set and is not part of the data (not explicitly marked as unbound). For example the column with delete button in this demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonikaKirkova I know what it is :) I was making the comment for @ChronosSF, because us, as developers of the product - we know how to create something like an unbound column, but developers who consume the library usually search for this in the docs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logged IgniteUI/igniteui-docfx#3388 to address this