Show number of defined columns as rowChangesCount for new row with batch editing #12234
Conversation
MonikaKirkova
added
grid: row-adding
version: 15.0.x
❌ status: awaiting-test
|
@MonikaKirkova please update the spec and check the last item from the checklist. |
| @@ -3219,6 +3219,9 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements | |||
| Object.keys(obj).forEach(key => isObject(obj[key]) ? changes += f(obj[key]) : changes++); | |||
| return changes; | |||
| }; | |||
| if (this.transactions.getState(this.crudService.row.id)?.type === TransactionType.ADD) { | |||
| return this._columns.filter(c => c.field).length; | |||
There was a problem hiding this comment.
Are there columns without a field and why are they excluded from the count?
There was a problem hiding this comment.
The field property of the unbound columns is undefined and there was a meeting where we discussed to include only the defined columns which are included in the data.
There was a problem hiding this comment.
@MonikaKirkova OK, makes sense. However, I'm not finding anything in the docs about unbound column. I didn't know we support this, nor can I find that it's done without specifying a field property value. @ChronosSF This last part of the comment should be addressed. It's not directed at Monika specifically :)
There was a problem hiding this comment.
By unbound column I mean a column, which field property is not set and is not part of the data (not explicitly marked as unbound). For example the column with delete button in this demo.
There was a problem hiding this comment.
@MonikaKirkova I know what it is :) I was making the comment for @ChronosSF, because us, as developers of the product - we know how to create something like an unbound column, but developers who consume the library usually search for this in the docs!
There was a problem hiding this comment.
Logged IgniteUI/igniteui-docfx#3388 to address this
ddaribo
added
💥 status: in-test
Closes #12212
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)