Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vision Glass] Correctly update applicationId for global App Gallery #1547

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[Vision Glass] Correctly update applicationId for global App Gallery #1547

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23561ac
Revert "[Vision Glass] Update app id for global App Gallery"
felipeerias Sep 25, 2024
c758d35
[Vision Glass] Correctly update applicationId for global App Gallery
felipeerias Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,18 @@ android {

}

androidComponents {
onVariants(selector().all()) { variant ->
def platform = variant.productFlavors.get(0).second
def store = variant.productFlavors.get(3).second

// Adjust the applicationId so it matches what the store expects.
if (platform == "visionglass" && store == "generic") {
variant.applicationId.set("com.igalia.wolvic.world.visionglass")
}
}
}

sourceSets {
main {
java.srcDirs = [
Expand Down Expand Up @@ -837,9 +849,6 @@ android.applicationVariants.configureEach { variant ->
variant.resValue 'string', 'HOMEPAGE_URL', '"https://wolvic.com/zh/start/pico.html"'
variant.buildConfigField "String[]", "SPEECH_SERVICES", "{ com.igalia.wolvic.speech.SpeechServices.MEETKAI }"
}
} else if (platform.toLowerCase().startsWith('visionglass')) {
// Adjust the applicationId so it matches what the store expects.
variant.mergedFlavor.applicationIdSuffix ".world.visionglass"
}

// Append "Dev" to the app name for debug builds. We do it by directly modifying the resource
Expand Down
Loading