[Vision Glass] Correctly update applicationId for global App Gallery #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
requested changes
Sep 25, 2024
app/build.gradle
Outdated
| @@ -436,6 +436,18 @@ android { | |||
|
|
|||
| } | |||
|
|
|||
| androidComponents { | |||
| onVariants(selector().withBuildType("release")) { variant -> | |||
There was a problem hiding this comment.
Not sure we want to limit it to release builds. I think this is also useful for testing, we might want to have both mainland china and world versions.
Also we already have some configureEach loops for finetuning variants, couldn't we integrate this into any of those?
There was a problem hiding this comment.
@svillar I have updated the PR so the changes apply to both release and debug builds.
Unfortunately the change in application Id needs to happen at a very specific time in the build process so I was not able to include it in our existing loops.
This reverts commit 09b98f2.
felipeerias
force-pushed
the
felipeerias/vgGenericAppId
branch
from
7bfb792
to
532ec60
Compare
To release Wolvic in the global App Gallery, we need to use this application ID:
com.igalia.wolvic.world.visionglass
This commit replaces an earlier one that was not working as expected.
felipeerias
force-pushed
the
felipeerias/vgGenericAppId
branch
from
532ec60
to
c758d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To release Wolvic in the global App Gallery, we need to use this application ID:
This change replaces an earlier one that was not working as expected.