schema: Fix broken upgrade script 1.3.0
#856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxzi
previously approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Oops. That should not have happened. Thanks to @alamp1360 for trying out the current development state.
The fix looks good. To make sure, I have compared the schema change and update script from #792 again.
Thanks for fixing!
PR #792 mistakenly added a `NOT NULL` clause to a nullable columns. This PR corrects that by dropping that clause and adding a `DEFAULT NULL` clause, making it consistent the actual schema file.
yhabteab
force-pushed
the
broken-upgrade-script
branch
from
d9cc373
to
f7cef36
Compare
|
Sorry, but I had to force push again because of this :), but it should be fine now! 4c4
< -- Host: localhost Database: icingadb
---
> -- Host: localhost Database: test_test
99c99
< `argument_key_override` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
---
> `argument_key_override` varchar(255) DEFAULT NULL,
393c393
< `argument_key_override` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
---
> `argument_key_override` varchar(255) DEFAULT NULL,
726c726
< ) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin ROW_FORMAT=DYNAMIC;
---
> ) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin ROW_FORMAT=DYNAMIC;
931c931
< `argument_key_override` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
---
> `argument_key_override` varchar(255) DEFAULT NULL,
1478c1478
< -- Dump completed on 2024-11-20 12:39:24
---
> -- Dump completed on 2024-11-20 12:39:36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #792 mistakenly added a
NOT NULLclause to a nullable columns. This PR corrects that by dropping that clause and adding aDEFAULT NULLclause, making it consistent the actual schema file.fixes #855