Skip to content

Commit

Permalink
schema: Fix broken upgrade script 1.3.0
Browse files Browse the repository at this point in the history
PR #792 mistakenly added a `NOT NULL` clause to a nullable columns. This
PR corrects that by dropping that clause and adding a `DEFAULT NULL`
clause, making it consistent the actual schema file.
  • Loading branch information
yhabteab committed Nov 20, 2024
1 parent 6c0611f commit f7cef36
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions schema/mysql/upgrades/1.3.0.sql
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ ALTER TABLE notification MODIFY COLUMN properties_checksum binary(20) NOT NULL C
ALTER TABLE timeperiod_range MODIFY COLUMN range_value text NOT NULL;

ALTER TABLE checkcommand_argument MODIFY COLUMN argument_key varchar(255) NOT NULL;
ALTER TABLE checkcommand_argument MODIFY COLUMN argument_key_override varchar(255) NOT NULL;
ALTER TABLE checkcommand_argument MODIFY COLUMN argument_key_override varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL;
ALTER TABLE eventcommand_argument MODIFY COLUMN argument_key varchar(255) NOT NULL;
ALTER TABLE eventcommand_argument MODIFY COLUMN argument_key_override varchar(255) NOT NULL;
ALTER TABLE eventcommand_argument MODIFY COLUMN argument_key_override varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL;
ALTER TABLE notificationcommand_argument MODIFY COLUMN argument_key varchar(255) NOT NULL;
ALTER TABLE notificationcommand_argument MODIFY COLUMN argument_key_override varchar(255) NOT NULL;
ALTER TABLE notificationcommand_argument MODIFY COLUMN argument_key_override varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL;

ALTER TABLE checkcommand_envvar MODIFY COLUMN envvar_key varchar(255) NOT NULL;
ALTER TABLE eventcommand_envvar MODIFY COLUMN envvar_key varchar(255) NOT NULL;
Expand Down

0 comments on commit f7cef36

Please sign in to comment.