Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix 5] - Operational learning bug fixes #1480

Merged
merged 17 commits into from
Dec 3, 2024

Conversation

samshara
Copy link
Member

@samshara samshara commented Nov 19, 2024

Addresses:

Depends on:

Changes

  • Excerpts - Secondary Summaries: Updated the label date of learning to date of operation and ensured the data reflects the start date of the operation.
  • Filter Titles: Changed the filter label Component to PER Component.
  • Translations: Resolved an issue with export translation where "export map" appeared incorrectly in other languages.
  • Sources: Fix a crash occurring when clicking the source for primary summaries in some filters (e.g., "Uganda").
  • Disclaimer Text: Updated the styling to align with the mockup for improved consistency and presentation.

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

tnagorra and others added 9 commits November 7, 2024 18:54
- Show exposure control only for GDACs source
- Update labels for severity control
    - Green -> 60 km/h
    - Orange -> 90 km/h
    - Red -> 120 km/h
- Update how event details is shown
    - Previously, we had a navigation system
    - Now, we have exandable container
- Fix issue related to richtext and excel
    - Filtered out empty text items
- Fix issue with injecting client id
    - We were injecting clientId instead of client_id
    - We were not injecting clientId if keyFieldName was defined
@samshara samshara requested a review from tnagorra November 19, 2024 07:19
@samshara samshara self-assigned this Nov 19, 2024
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 9fa28db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samshara samshara changed the base branch from develop to hotfix/cos-health-updates November 19, 2024 07:23
@samshara samshara changed the title Hotfix[4] - Operational learning bug fixes Hotfix[5] - Operational learning bug fixes Nov 19, 2024
@tnagorra tnagorra changed the title Hotfix[5] - Operational learning bug fixes [Hotfix 5] - Operational learning bug fixes Nov 19, 2024
@tnagorra
Copy link
Member

@samshara Shouldn't this be merged on fix/cos-health-main-text

@samshara samshara force-pushed the hotfix/operational-learning branch from d018b13 to 3f9aa4f Compare November 20, 2024 12:32
@samshara samshara changed the base branch from hotfix/cos-health-updates to fix/cos-health-main-text November 22, 2024 11:06
@samshara samshara changed the base branch from fix/cos-health-main-text to release December 3, 2024 10:54
@samshara samshara marked this pull request as ready for review December 3, 2024 10:55
@samshara samshara merged commit 1e8e5e6 into release Dec 3, 2024
7 checks passed
@samshara samshara deleted the hotfix/operational-learning branch December 3, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants