Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix 4]: Replace the from-communication-copied text of CoS Health header #1472

Closed

Conversation

szabozoltan69
Copy link
Collaborator

Refers to a correspondence with Surge team, where it was flagged that the Communications and Health has the same intro text.

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: ecca810

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
go-web-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samshara samshara changed the base branch from develop to hotfix/cos-health-updates November 15, 2024 09:55
@samshara samshara changed the base branch from hotfix/cos-health-updates to develop November 15, 2024 09:56
Copy link
Member

@samshara samshara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szabozoltan69 the PR needs to be sent to the hotfix/cos-health-updates branch as the base branch instead of develop.

@szabozoltan69 szabozoltan69 changed the base branch from develop to hotfix/cos-health-updates November 15, 2024 10:55
@szabozoltan69 szabozoltan69 dismissed samshara’s stale review November 15, 2024 11:08

The request is done, changed base branch and conflicts solved.

@samshara
Copy link
Member

@szabozoltan69, some commits here are not relevant to the hotfix. Please cherry-pick only the necessary commits for the hotfix. Based on the review, it seems we only need this commit: aafa45e. Thanks.

@samshara samshara force-pushed the fix/cos-health-main-text branch from 25cd5d2 to ecca810 Compare November 19, 2024 07:30
@samshara samshara changed the title Replace the from-communication-copied text of CoS Health header [Hotfix-4]: Replace the from-communication-copied text of CoS Health header Nov 19, 2024
@samshara samshara marked this pull request as draft November 19, 2024 07:32
@samshara
Copy link
Member

@szabozoltan69 I’ve cherry-picked your commit. Instead of merging it now, we’ll include it in an upcoming hotfix deployment.

@tnagorra tnagorra changed the title [Hotfix-4]: Replace the from-communication-copied text of CoS Health header [Hotfix 4]: Replace the from-communication-copied text of CoS Health header Nov 19, 2024
@szabozoltan69 szabozoltan69 marked this pull request as ready for review November 19, 2024 10:55
@tnagorra tnagorra marked this pull request as draft November 20, 2024 08:17
@samshara samshara self-assigned this Nov 27, 2024
@samshara
Copy link
Member

samshara commented Dec 3, 2024

included in #1480

@samshara samshara closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants