Making disconnect button work based on the port on the Dropdown list.

HenriquesLab · Aug 18, 2018 · 3699c8c · 3699c8c
1 parent 303d44d
commit 3699c8c
Show file tree

Hide file tree

Showing 9 changed files with 53 additions and 13 deletions.
diff --git a/NanoJ-Fluidics.jar b/NanoJ-Fluidics.jar
diff --git a/NanoJ-Fluidics_IJ.jar b/NanoJ-Fluidics_IJ.jar
diff --git a/NanoJ-Fluidics_MM.jar b/NanoJ-Fluidics_MM.jar
diff --git a/PackagedBinaries/NanoJ-Fluidics.zip b/PackagedBinaries/NanoJ-Fluidics.zip
diff --git a/PackagedBinaries/NanoJ-Fluidics_IJ.zip b/PackagedBinaries/NanoJ-Fluidics_IJ.zip
diff --git a/PackagedBinaries/NanoJ-Fluidics_MM.zip b/PackagedBinaries/NanoJ-Fluidics_MM.zip
diff --git a/src/nanoj/pumpControl/java/pumps/ConnectedSubPumpsList.java b/src/nanoj/pumpControl/java/pumps/ConnectedSubPumpsList.java
@@ -36,11 +36,15 @@ public void removePump(String pumpName,String port) {
     }
 
     public void removePump(Pump pump) {
+        ArrayList<ConnectedSubPump> found = new ArrayList<ConnectedSubPump>();
         for (ConnectedSubPump subPump: list)
-            if (subPump.name.equals(pump.name))
-                list.remove(subPump);
+            if (subPump.pump.equals(pump))
+                found.add(subPump);
 
-        connectedPumps.remove(pump);
+        for (ConnectedSubPump foundPump : found)
+            list.remove(foundPump);
+
+        connectedPumps.remove(found.get(0).pump);
     }
 
     public ConnectedSubPump getConnectedSubPump(String name, String subPump, String port) throws PumpNotFoundException {

diff --git a/src/nanoj/pumpControl/java/pumps/PumpManager.java b/src/nanoj/pumpControl/java/pumps/PumpManager.java
@@ -124,6 +124,24 @@ public synchronized void stopPumping(String pumpName, String subPump, String por
         notifyObservers(NEW_STATUS_AVAILABLE);
     }
 
+    public synchronized boolean disconnect(String port) throws Exception {
+        boolean success = false;
+        Pump pump = null;
+        for (ConnectedSubPump subPump: connectedSubPumps)
+            if (subPump.port.equals(port)) {
+                pump = subPump.pump;
+                success = subPump.pump.disconnect();
+                break;
+            }
+
+        if (success)
+            connectedSubPumps.removePump(pump);
+
+        setChanged();
+        notifyObservers(PUMP_DISCONNECTED);
+        return success;
+    }
+
     public synchronized boolean disconnect(int index) throws Exception {
         boolean success = connectedSubPumps.getConnectedSubPump(index).pump.disconnect();
         String name = connectedSubPumps.getConnectedSubPump(index).name;
@@ -147,6 +165,28 @@ public ConnectedSubPumpsList getConnectedPumpsList() {
         return connectedSubPumps;
     }
 
+    public Pump getPumpOnPort(String port) {
+        Pump pump = null;
+        for (ConnectedSubPump subPump: connectedSubPumps)
+            if (subPump.port.equals(port)) {
+                pump = subPump.pump;
+                break;
+            }
+
+        return pump;
+    }
+
+    public String getPumpNameOnPort(String port) {
+        String pump = "Not found";
+        for (ConnectedSubPump subPump: connectedSubPumps)
+            if (subPump.port.equals(port)) {
+                pump = subPump.name;
+                break;
+            }
+
+        return pump;
+    }
+
     public synchronized boolean isConnected(int pumpIndex) {
         return connectedSubPumps != null &&
                 pumpIndex < connectedSubPumps.size() &&

diff --git a/src/nanoj/pumpControl/java/sequentialProtocol/tabs/PumpConnections.java b/src/nanoj/pumpControl/java/sequentialProtocol/tabs/PumpConnections.java
@@ -104,16 +104,12 @@ private class Disconnect implements ActionListener {
         @Override
         public void actionPerformed(ActionEvent e) {
             boolean success = false;
-            if (connectedPumpsTable.getSelectedRow() < 0) {
-                return;
-            }
-            String pump = null;
-            String port = null;
+            String port = "Undefined";
+            String name = "Undefined";
             try {
-                int selection = connectedPumpsTable.getSelectedRow();
-                success = pumpManager.disconnect(selection);
-                pump = (String) connectedPumpsTableModel.getValueAt(selection,0);
-                port = (String) connectedPumpsTableModel.getValueAt(selection,2);
+                port = (String) portsList.getSelectedItem();
+                name = pumpManager.getPumpNameOnPort(port);
+                success = pumpManager.disconnect(port);
             } catch (Exception e1) {
                 gui.log.message("Error, failed to disconnect properly.");
                 e1.printStackTrace();
@@ -124,7 +120,7 @@ public void actionPerformed(ActionEvent e) {
                 for (ConnectedSubPump subPump: pumpManager.getConnectedPumpsList())
                     connectedPumpsTableModel.addRow(subPump.asConnectionArray());
 
-                gui.log.message("Disconnected from " + pump + " on port " + port + ".");
+                gui.log.message("Disconnected from " + name + " on port " + port + ".");
             }
         }
     }