Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imports #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add imports #116

wants to merge 2 commits into from

Conversation

Hellebore
Copy link
Owner

No description provided.

@ghost ghost mentioned this pull request Nov 2, 2020
@ghost
Copy link

ghost commented Nov 2, 2020

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 52.76 ⛔ 52.76 ⛔ 0.00
Method Length 48.00 ⭐ 45.40 ⭐ -2.60 👍
Working memory 7.94 🙂 7.94 🙂 0.00
Quality 47.38% 😞 47.38% 😞 0.00%
Other metrics Before After Change
Lines 37 52 15
Changed files Quality Before Quality After Quality Change
gilded_rose_original.py 47.38% 😞 47.38% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gilded_rose_original.py GildedRose.update_quality 69 ⛔ 150 😞 9 🙂 32.69% 😞 Refactor to reduce nesting. Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 2, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.11%.

Quality metrics Before After Change
Complexity 17.25 🙂 13.80 🙂 -3.45 👍
Method Length 48.00 ⭐ 45.40 ⭐ -2.60 👍
Working memory 5.50 ⭐ 5.40 ⭐ -0.10 👍
Quality 79.99% 82.10% 2.11% 👍
Other metrics Before After Change
Lines 37 52 15
Changed files Quality Before Quality After Quality Change
gilded_rose_original.py 79.99% ⭐ 82.10% ⭐ 2.11% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gilded_rose_original.py GildedRose.update_quality 69 ⛔ 150 😞 9 🙂 32.69% 😞 Refactor to reduce nesting. Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant