-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add imports (Sourcery refactored) #117
Conversation
c9bd22a
to
b5cf8e8
Compare
if item.name != "Aged Brie" and item.name != "Backstage passes to a TAFKAL80ETC concert": | ||
if item.quality > 0: | ||
if item.name != "Sulfuras, Hand of Ragnaros": | ||
item.quality = item.quality - 1 | ||
else: | ||
if item.name == "Sulfuras, Hand of Ragnaros": | ||
continue | ||
if item.name == "Aged Brie": | ||
if item.quality < 50: | ||
item.quality = item.quality + 1 | ||
if item.sell_in < 1 and item.quality < 50: | ||
item.quality = item.quality + 1 | ||
|
||
elif item.name == "Backstage passes to a TAFKAL80ETC concert": | ||
if item.quality < 50: | ||
item.quality = item.quality + 1 | ||
if item.name == "Backstage passes to a TAFKAL80ETC concert": | ||
if item.sell_in < 11: | ||
if item.quality < 50: | ||
item.quality = item.quality + 1 | ||
if item.sell_in < 6: | ||
if item.quality < 50: | ||
item.quality = item.quality + 1 | ||
if item.name != "Sulfuras, Hand of Ragnaros": | ||
item.sell_in = item.sell_in - 1 | ||
if item.sell_in < 0: | ||
if item.name != "Aged Brie": | ||
if item.name != "Backstage passes to a TAFKAL80ETC concert": | ||
if item.quality > 0: | ||
if item.name != "Sulfuras, Hand of Ragnaros": | ||
item.quality = item.quality - 1 | ||
else: | ||
item.quality = item.quality - item.quality | ||
else: | ||
if item.quality < 50: | ||
item.quality = item.quality + 1 | ||
if item.sell_in < 11 and item.quality < 50: | ||
item.quality = item.quality + 1 | ||
if item.sell_in < 6 and item.quality < 50: | ||
item.quality = item.quality + 1 | ||
if item.sell_in < 1: | ||
item.quality = item.quality - item.quality | ||
else: | ||
if item.quality > 0: | ||
item.quality = item.quality - 1 | ||
if item.sell_in < 1 and item.quality > 0: | ||
item.quality = item.quality - 1 | ||
item.sell_in = item.sell_in - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function GildedRose.update_quality
refactored with the following changes:
- Simplify conditional into switch-like form (
switch
) - Merge nested if conditions (
merge-nested-ifs
) - Swap positions of nested conditionals (
swap-nested-ifs
) - Remove redundant conditional (
remove-redundant-if
) - Remove empty elif clause (
remove-pass-elif
) - Replace multiple comparisons of same variable with
in
operator (merge-comparisons
) - Ensure first condition in if is positive (
swap-if-else-branches
) - Split conditional into multiple branches (
split-or-ifs
) - Hoist conditional out of nested conditional (
hoist-if-from-if
) - Extract guard clause from elif block (
guard
) - Hoist repeated code outside conditional statement (
hoist-statement-from-if
) - Simplify numeric comparison (
simplify-numeric-comparison
)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 6.68%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Pull Request #116 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
import_test
branch, then run: