Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blockchainodeengine api to infra file #9386

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Oct 31, 2023

References hashicorp/terraform-provider-google#16388
Required in order to add Google Blockchain Node Engine resource

Release Note Template for Downstream PRs (will be copied)


@BBBmau
Copy link
Collaborator Author

BBBmau commented Oct 31, 2023

Referencing REST doc

@BBBmau
Copy link
Collaborator Author

BBBmau commented Nov 14, 2023

Looking to get this merged to get hashicorp/terraform-provider-google#16388 added.

What else is required? @roaks3

@roaks3 roaks3 self-requested a review November 15, 2023 22:05
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's interesting, it didn't auto-assign a reviewer for you. LGTM, I will need to enable the API in each environment, and then I'll merge this once that's done.

@roaks3
Copy link
Contributor

roaks3 commented Nov 15, 2023

Done

@enotf
Copy link

enotf commented Feb 6, 2024

@BBBmau many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants