Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blockchain Engine API Resource Support #1898

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#16388

Requires GoogleCloudPlatform/magic-modules#9386 to be merged

Release Note Template for Downstream PRs (will be copied)

`google_blockchain_nodes`

Derived from GoogleCloudPlatform/magic-modules#9395

* add blockchain yaml

* add blockchain product yaml

* add location parameter

* fix lint tests

* remove ApiReference from product yaml

* remove required from location parameters

* add location parameter into test

* add missing

* update tests to use proper blockchain values

* add missing query parameters and create_url in resource

* remove self_link

* Fix inconsistent apply

* Add async support

* lint fixes

* add gethdetails test

* fix node_id typo

* fix test config typos

* typo

* fix output only values

* use NestedObject

* add endline after block

* make additionalEndpoints output only

* WIP: import format

* add self_link of blockchain node

* update import_format

* update self_link

* blockchain_node_id in import_format

* name as import_format

* update directory + explicitly set import_path

* Update mmv1/products/blockchainnodeengine/BlockchainNodes.yaml

Co-authored-by: Sarah French <[email protected]>

* use autogen_async, remove ignore_read,default_from_api

* requested changes to yaml fields

* Update mmv1/products/blockchainnodeengine/BlockchainNodes.yaml

Co-authored-by: Sarah French <[email protected]>

* Update mmv1/products/blockchainnodeengine/BlockchainNodes.yaml

Co-authored-by: Sarah French <[email protected]>

* add validator_config field in tests

* add mev_relay_urls test check

* type

---------

Co-authored-by: Sarah French <[email protected]>
[upstream:c4dad9977780ff8ed3e98c30ea0f52a1daedfd52]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner January 24, 2024 16:19
@modular-magician modular-magician requested review from melinath and removed request for a team January 24, 2024 16:19
@modular-magician modular-magician merged commit bada3ed into GoogleCloudPlatform:main Jan 24, 2024
3 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-c4dad9977780ff8ed3e98c30ea0f52a1daedfd52 branch November 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new resource for Google Blockchain Node Engine
1 participant