KMS_config_first_commit #9353

ranandku · 2023-10-25T05:55:53Z

Fixes - hashicorp/terraform-provider-google#16355

This PR is to support provisioning kmsConfigs for Google Cloud NetApp Volumes through GCP terraform provider.

`google_netapp_kmsconfig`

google-cla · 2023-10-25T05:55:57Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modular-magician · 2023-10-25T05:57:13Z

Hello! I am a robot. It looks like you are a: Community Contributor ~~Googler~~ ~~Core Contributor~~. Tests will require approval to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

ranandku · 2023-10-25T06:01:04Z

@NickElliot - Just signed the CLA

NickElliot · 2023-10-26T19:03:17Z

/gcbrun

NickElliot · 2023-10-26T19:06:13Z

The CLA check is still failing, which appears to be because the email associated with your commits is not the email associated with your CLA

ranandku · 2023-10-27T11:19:21Z

@NickElliot - Have fixed the CLA issue

NickElliot

Hi, the build is failing with the following:

Please use type KeyValueLabels for field labels in resource Netapp/kmsconfig (RuntimeError)

modular-magician · 2023-11-08T23:08:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 1156 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 1156 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_kmsconfig (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_kmsconfig" "primary" {
  labels = # value needed
}

modular-magician · 2023-11-09T00:21:23Z

Tests analytics

Total tests: 3225
Passed tests 2895
Skipped tests: 328
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappkmsconfig_kmsConfigCreateExample_Update|TestAccNetappkmsconfig_kmsConfigCreateExample

Get to know how VCR tests work

modular-magician · 2023-11-09T00:23:33Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappkmsconfig_kmsConfigCreateExample_Update[Error message] [Debug log]
TestAccNetappkmsconfig_kmsConfigCreateExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

ranandku · 2023-11-09T16:46:55Z

@NickElliot - Can you please the test error logs for us to take a look at it?

NickElliot

Sorry about the delay, one error explanation and one needed change :)

NickElliot · 2023-11-09T18:44:17Z

mmv1/templates/terraform/examples/kmsConfig_create.tf.erb

+  kms_name = "<%= ctx[:vars]['kms_name'] %>"
+  description="this is a test description"
+  crypto_key_name="projects/cxo-automation-gcp/locations/us-central1/keyRings/kmsRing2/cryptoKeys/kmsCrypto111"
+  location="usthis is a test description-central1"


Error: Error creating kmsconfig: googleapi: Error 403: Permission denied on 'locations/usthis is a test description-central1' (or it may not exist).

with google_netapp_kmsconfig.kmsConfig, on terraform_plugin_test.tf line 2, in resource "google_netapp_kmsconfig" "kmsConfig": 2: resource "google_netapp_kmsconfig" "kmsConfig" {

appears to be a problem here! also could you update this sample to be using a cryptokey terraform resource for the crypto_key_name

NickElliot · 2023-11-09T18:44:32Z

mmv1/third_party/terraform/services/netapp/resource_netapp_kmsconfig_test.go

+resource "google_netapp_kmsconfig" "kmsConfig" {
+  kms_name = "tf-test-kms-test%{random_suffix}"
+  description=""
+  crypto_key_name="projects/cxo-automation-gcp/locations/us-central1/keyRings/kmsRing2/cryptoKeys/kmsCrypto111"


same thing here! need a crypto key resource in config

ranandku · 2023-11-15T06:02:01Z

@NickElliot I have updated the crypto_key_name and fixed the above errors.

modular-magician · 2023-11-15T20:55:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 1200 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 1200 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_kmsconfig (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_kmsconfig" "primary" {
  labels = # value needed
}

modular-magician · 2023-11-15T22:08:26Z

Tests analytics

Total tests: 3232
Passed tests 2900
Skipped tests: 330
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappkmsconfig_kmsConfigCreateExample_Update|TestAccNetappkmsconfig_kmsConfigCreateExample

Get to know how VCR tests work

modular-magician · 2023-11-15T22:10:37Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappkmsconfig_kmsConfigCreateExample_Update[Error message] [Debug log]
TestAccNetappkmsconfig_kmsConfigCreateExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

okrause · 2024-01-08T12:56:47Z

@NickElliot Can you please have another look? Test look good to me now.

modular-magician · 2024-01-08T21:16:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1047 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1047 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2024-01-08T21:19:12Z

Tests analytics

Total tests: 6
Passed tests 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappkmsconfig_kmsConfigCreateExample_Update

Get to know how VCR tests work

modular-magician · 2024-01-08T21:19:39Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappkmsconfig_kmsConfigCreateExample_Update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

NickElliot

Still experiencing the same error - I suggested removing the parallelization of the test so it should not happen until the other test is fully finished, and moving the tests back to us-central1. Sorry for the extremely prolonged review.

NickElliot · 2024-01-08T21:43:50Z

mmv1/third_party/terraform/services/netapp/resource_netapp_kmsconfig_test.go

+)
+
+func TestAccNetappkmsconfig_kmsConfigCreateExample_Update(t *testing.T) {
+	t.Parallel()


Suggested change

t.Parallel()

Woot! This is a missing link I was looking for in the last weeks. We have multiple resources (Active Directory, KSMconfig, BackupVault) which are unique per region and tests are failing when ran in parallel. We worked around that so far, but this is the best way to solve that. I learned something important. Thank you!

But I am still surprised the tests did fail. We ran them in two different regions, so they shouldn't impact each other. Let us incorporate your suggestions and see how it works. My local test works fine.

NickElliot · 2024-01-08T21:44:13Z

mmv1/third_party/terraform/services/netapp/resource_netapp_kmsconfig_test.go

+	return acctest.Nprintf(`
+	resource "google_kms_key_ring" "keyring" {
+		name     = "tf-test-key-ring%{random_suffix}"
+		location = "us-west1"


Suggested change

location = "us-west1"

location = "us-central1"

NickElliot · 2024-01-08T21:44:25Z

mmv1/third_party/terraform/services/netapp/resource_netapp_kmsconfig_test.go

+	return acctest.Nprintf(`
+	resource "google_kms_key_ring" "keyring" {
+		name     = "tf-test-key-ring%{random_suffix}"
+		location = "us-west1"


Suggested change

location = "us-west1"

location = "us-central1"

NickElliot · 2024-01-08T21:44:53Z

mmv1/third_party/terraform/services/netapp/resource_netapp_kmsconfig_test.go

+		name = "tf-test-kms-test%{random_suffix}"
+		description="this is a test description"
+		crypto_key_name=google_kms_crypto_key.crypto_key.id
+		location="us-west1"


Suggested change

location="us-west1"

location = "us-central1"

NickElliot · 2024-01-08T21:45:13Z

mmv1/third_party/terraform/services/netapp/resource_netapp_kmsconfig_test.go

+		name = "tf-test-kms-test%{random_suffix}"
+		description="kmsconfig update"
+		crypto_key_name=google_kms_crypto_key.crypto_key.id
+		location="us-west1"


Suggested change

location="us-west1"

location = "us-central1"

modular-magician · 2024-01-09T17:58:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1047 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1047 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 96 insertions(+))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2024-01-09T18:01:53Z

Tests analytics

Total tests: 6
Passed tests 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappkmsconfig_kmsConfigCreateExample_Update

Get to know how VCR tests work

modular-magician · 2024-01-09T18:03:50Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappkmsconfig_kmsConfigCreateExample_Update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

NickElliot

At last everything is good! Thank you for your contribution.

okrause · 2024-01-09T23:42:49Z

Thank you for your review. Very appreciated!

* KMS_config_first_commit * kmscommit for author change * Updated label to KeyValueLabels * kmsconfig_update_key_ring_crypto_key_name * Fixed issues in resource_netapp_kmsconfig_test.go * removed roation_period * changed location to us-west1 * fixed double quotes * changes_with_labels * changed location to us-central1

…s in state by config order

* KMS_config_first_commit * kmscommit for author change * Updated label to KeyValueLabels * kmsconfig_update_key_ring_crypto_key_name * Fixed issues in resource_netapp_kmsconfig_test.go * removed roation_period * changed location to us-west1 * fixed double quotes * changes_with_labels * changed location to us-central1

…g order (#10572) Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Sarah French <[email protected]>

…s in state by config order (GoogleCloudPlatform#10572) Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Sarah French <[email protected]>

KMS_config_first_commit

119d353

modular-magician requested a review from NickElliot October 25, 2023 05:57

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 25, 2023

kmscommit for author change

4131ad6

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 30, 2023

G-NamanGupta mentioned this pull request Nov 6, 2023

updated storage_pool #9229

Merged

NickElliot requested changes Nov 6, 2023

View reviewed changes

Updated label to KeyValueLabels

f034bbf

modular-magician requested a review from NickElliot November 7, 2023 06:22

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Nov 7, 2023

NickElliot requested changes Nov 9, 2023

View reviewed changes

kmsconfig_update_key_ring_crypto_key_name

ab6e4a8

modular-magician requested a review from NickElliot November 15, 2023 05:58

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 15, 2023

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 15, 2023

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 8, 2024

NickElliot requested changes Jan 8, 2024

View reviewed changes

changed location to us-central1

4b48673

modular-magician requested a review from NickElliot January 9, 2024 12:46

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 9, 2024

NickElliot approved these changes Jan 9, 2024

View reviewed changes

NickElliot merged commit 08644b8 into GoogleCloudPlatform:main Jan 9, 2024
13 checks passed

shuyama1 mentioned this pull request Jan 10, 2024

Adding support for Google Cloud NetApp kmsConfigs hashicorp/terraform-provider-google#16355

Closed

Maarc-D added a commit to Maarc-D/magic-modules that referenced this pull request Mar 5, 2024

fix(types-for-idempotence): related to issue GoogleCloudPlatform#9353

bb26f2b

LucaPrete pushed a commit to LucaPrete/magic-modules that referenced this pull request May 1, 2024

[GoogleCloudPlatform#9353] Make cloud router sort advertised_ip_range…

680b916

…s in state by config order

SarahFrench added a commit that referenced this pull request May 23, 2024

[#9353] Make cloud router sort advertised_ip_ranges in state by confi…

43a016f

…g order (#10572) Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Sarah French <[email protected]>

KMS_config_first_commit #9353

KMS_config_first_commit #9353

Conversation

ranandku commented Oct 25, 2023 • edited by NickElliot Loading

google-cla bot commented Oct 25, 2023

modular-magician commented Oct 25, 2023

ranandku commented Oct 25, 2023

NickElliot commented Oct 26, 2023

NickElliot commented Oct 26, 2023

ranandku commented Oct 27, 2023

NickElliot left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 8, 2023

Diff report

Missing test report

modular-magician commented Nov 9, 2023

Tests analytics

Action taken

modular-magician commented Nov 9, 2023

ranandku commented Nov 9, 2023

NickElliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ranandku commented Nov 15, 2023

modular-magician commented Nov 15, 2023

Diff report

Missing test report

modular-magician commented Nov 15, 2023

Tests analytics

Action taken

modular-magician commented Nov 15, 2023

okrause commented Jan 8, 2024

modular-magician commented Jan 8, 2024

Diff report

modular-magician commented Jan 8, 2024

Tests analytics

Action taken

modular-magician commented Jan 8, 2024

NickElliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jan 9, 2024

Diff report

modular-magician commented Jan 9, 2024

Tests analytics

Action taken

modular-magician commented Jan 9, 2024

Rerun these tests in REPLAYING mode to catch issues

NickElliot left a comment

Choose a reason for hiding this comment

okrause commented Jan 9, 2024

ranandku commented Oct 25, 2023 •

edited by NickElliot

Loading