Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 - remove computed keys from JSON in monitoring dashboard #9065

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 23, 2023

rebasing #5595
fixes hashicorp/terraform-provider-google#7242
upgrade guide: #8970

Release Note Template for Downstream PRs (will be copied)

monitoring: fixed perma-diffs in `google_monitoring_dashboard.dashboard_json` by suppressing values returned by the API that are not in configuration

@google-cla

This comment was marked as off-topic.

@c2thorn c2thorn changed the base branch from main to FEATURE-BRANCH-major-release-5.0.0 September 23, 2023 03:34
@c2thorn c2thorn changed the title 5.0.0 monitoring dashboard 5.0.0 - remove computed keys from JSON in monitoring dashboard Sep 23, 2023
@c2thorn c2thorn mentioned this pull request Sep 23, 2023
5 tasks
@c2thorn c2thorn force-pushed the 5.0.0-monitoring-dashboard branch from 36eb8fd to 323fbf2 Compare September 23, 2023 03:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3082
Passed tests 2768
Skipped tests: 313
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_withSandboxConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withSandboxConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn c2thorn requested a review from slevenick September 25, 2023 15:40
@c2thorn c2thorn merged commit 262bbe6 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0 Sep 26, 2023
8 checks passed
@c2thorn c2thorn deleted the 5.0.0-monitoring-dashboard branch September 26, 2023 22:18
etruong42 added a commit to etruong42/magic-modules that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_monitoring_dashboard: resource always need to be updated.
3 participants