-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.0 - remove computed keys from JSON in monitoring dashboard #9065
5.0.0 - remove computed keys from JSON in monitoring dashboard #9065
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
36eb8fd
to
323fbf2
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 35 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerNodePool_withSandboxConfig |
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/monitoring/resource_monitoring_dashboard.go
Show resolved
Hide resolved
262bbe6
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
GoogleCloudPlatform#9065)" This reverts commit 262bbe6. That commit introduced the issue at hashicorp/terraform-provider-google#16439
rebasing #5595
fixes hashicorp/terraform-provider-google#7242
upgrade guide: #8970
Release Note Template for Downstream PRs (will be copied)