Sync Feature branch major release 5.0.0 into main #9110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enhance BigQuery table schema input validation * skip TestAccBigQueryTable_invalidSchemas in VCR test
Sync 5.0.0 with main Part 3
…in BigQuery table config (#7973) * Enforce mutual exclusivity among view, materialized view, and schema in BigQuery table config * fix merge conflict * fix field specification and add a VCR skip for the new acceptance test * skip VCR for MaterializedView_WithView test too
Sync 5.0.0 with main
…8600) Instead of using a hardcode default of `false` for `enableEndpointIndependentMapping`, use the default value from the API.
* Add new type KeyValueLabels * Use KeyValueLabels in resource google_compute_address * func access_path in type * Add new type KeyValueAnnotations * Add new type KeyValueAnnotations * Fix the syntax error * Modify descriptions for labels field * Fix tests * Only read labels fingerprint when set labels * Remove version check * Fix tgc * Refactor code * Remove logger * New function properities_with_excluded * Address comments * Revert the TGC changes * Fix rake syntax errors * Fix the bug to set labels in the state * Type transform
* Modify labels fields * effective_labels filed is not optional * Add tests for labels * Append notes for lables description * Fix the notes
* Modify lables field * Fix description * Fix tests * Ignore labels for import state verify * Ignore labels for import state verify
* Remove Terraform support for game services * Remove game_service from provider.go * Remove gameServices from ci file
Co-authored-by: Cameron Thornton <[email protected]>
…tions (#8780) Co-authored-by: Cameron Thornton <[email protected]>
…source google_compute_security_policy (#8804)
* Add provider default labels * Fix the filed names * Fix the field name * Don't expand lables field * Fix syntax errors * Fix bug to set metadata.0.terraform_labels * Ignore state verify for terraform_labels * Add logs * Add more logs * Skip test if vcr is enabled * Add new type KeyValueTerraformLabels * Fix rake test * Add terraform_labels to tfplan.json files * Comment out tgc integration tests
* updated regex * removing prefix fron vpntunnel text, updating billing info for allowing supplied uris wth a trailing * replacing importstateid, skipping import in generated sample * incorrect var
* Apply labels model to compute instance template * Check if terraform_labels and effective_labels are in schema * Test out of band labels
# Conflicts: # .ci/containers/membership-checker/membership.go # .ci/gcb-community-checker.yml # .ci/gcb-contributor-membership-checker.yml # .ci/magician/github/membership.go # mmv1/products/alloydb/Backup.yaml # mmv1/products/secretmanager/Secret.yaml # mmv1/products/securitycenter/ProjectCustomModule.yaml # mmv1/templates/terraform/examples/scc_project_custom_module_basic.tf.erb # mmv1/templates/terraform/examples/scc_project_custom_module_full.tf.erb # mmv1/templates/terraform/examples/workstation_config_basic.tf.erb # mmv1/third_party/terraform/services/alloydb/resource_alloydb_instance_test.go # mmv1/third_party/terraform/services/securitycenter/resource_scc_project_custom_module_test.go # mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 879 files changed, 24489 insertions(+), 18703 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
resources = # value needed
}
status {
resources = # value needed
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
resources = # value needed
}
status {
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryExternalDataTable_queryAcceleration|TestAccBigQueryExternalDataTable_parquetFileSetSpecType|TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster|TestAccContainerCluster_withMultiNetworking|TestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 879 files changed, 24489 insertions(+), 18703 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_access_context_manager_service_perimeter" "primary" {
spec {
resources = # value needed
}
status {
resources = # value needed
}
}
Resource: resource "google_access_context_manager_service_perimeters" "primary" {
service_perimeters {
spec {
resources = # value needed
}
status {
resources = # value needed
}
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withAddons |
|
|
shuyama1
approved these changes
Sep 28, 2023
This was referenced Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
#8460
#8458
#8529
#7973
#8600
#8583
#8573
#8327
#8531
#8669
#8118
#8780
#8804
#8569
#8868
#8670
#8875
#8788
#8872
#8783
#8858
#8928
#8929
#8859
#8784
#8978
#9026
#8965
#8967
#8904
#9043
#9014
#9033
#9011
#9031
#9050
#8913
#9058
#8914
#9055
#9044
#8823
#9013
#9065