-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed tests related to google_service_networking_connection #8904
Fix failed tests related to google_service_networking_connection #8904
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 19 files changed, 59 insertions(+), 61 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork |
Rerun these tests in REPLAYING mode to catch issues
|
1bba746
to
e853455
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 19 files changed, 59 insertions(+), 61 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccServiceNetworkingConnection_create|TestAccServiceNetworkingConnection_update |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, I believe bootstrapping is still needed for this PR
7624060
to
fa4a1af
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 19 files changed, 295 insertions(+), 504 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_update|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbCluster_restore|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_update|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeTargetServer_apigeeTargetServerTestExample|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApigeeTargetServer_apigeeTargetServerTest_update|TestAccBackupDRManagementServer_backupDrManagementServerExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccMemcacheInstance_update|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccServiceNetworkingConnection_create|TestAccServiceNetworkingConnection_update|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange1|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample |
Rerun these tests in REPLAYING mode to catch issues
|
9090d3f
to
f4264e9
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 19 files changed, 295 insertions(+), 504 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbInstance_update|TestAccAlloydbCluster_restore|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbBackup_update|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccMemcacheInstance_update|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange1|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 19 files changed, 351 insertions(+), 648 deletions(-)) |
dafdb0e
to
bfc0ef1
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 19 files changed, 352 insertions(+), 646 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbInstance_update|TestAccAlloydbBackup_update|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbCluster_restore|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbBackup_usingCMEK|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccMemcacheInstance_update|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_settings_checkServiceNetworking|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork |
Rerun these tests in REPLAYING mode to catch issues
|
bfc0ef1
to
025e43e
Compare
45f8b09
to
40e1dc1
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 19 files changed, 396 insertions(+), 696 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_restore|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccProjectIamPolicy_invalidMembers |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 22 files changed, 463 insertions(+), 787 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb |
Rerun these tests in REPLAYING mode to catch issues
|
The failed tests are unrelated. |
The previous PR #8872 caused some nightly tests failed.
google_service_networking_connection
resource, call the method deleteConnection. If it fails, return the error and the deletion fails. Based on the test results, only sql instance has a waiting period to delete the connection.5.0 guide is in #9009
Release Note Template for Downstream PRs (will be copied)