-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source addition for Backupdr Beta #8854
Conversation
Backupdr ms
Fixing lint issue
Fixing Variable name
FIxing values of type and peering mode
Fixing description and example
Adding type and Peering_mode to coverage
Changing release version of provider to only beta
Changing variable name
Fixing Acceptance test and trademark
datasource changes
Hello! I am a robot. It looks like you are a: @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccFolderIamPolicy_basic |
Rerun these tests in REPLAYING mode to catch issues
|
Looks like unit tests failed due to lint error:
|
mmv1/third_party/terraform/tests/data_source_backup_dr_management_server_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/data_source_backup_dr_management_server_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/data_source_backup_dr_management_server_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/backupdr/data_source_backup_dr_management_server.go
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Only some small comments + nitpicks! Thank you!
mmv1/third_party/terraform/services/backupdr/data_source_backup_dr_management_server.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/services/backupdr/data_source_backup_dr_management_server.go.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Shuya Ma <[email protected]>
1) Added inline comment 2) Edited error string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes of inline comment and error string modication addressed.
1 similar comment
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy|TestAccHealthcareDatasetIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
.../third_party/terraform/services/backupdr/data_source_backup_dr_management_server_test.go.erb
Outdated
Show resolved
Hide resolved
…p_dr_management_server_test.go.erb
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleBackupDRManagementServer_basic |
|
.../third_party/terraform/services/backupdr/data_source_backup_dr_management_server_test.go.erb
Outdated
Show resolved
Hide resolved
…p_dr_management_server_test.go.erb
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleBackupDRManagementServer_basic |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Adding data source changes to backupdr to access already existing resource through terraform
Completing the checklist will help speed up the review process, and we appreciate you spending time on them before sending
your code to be reviewed.
If your PR is still work in progress, please create it in draft mode
-->
Release Note Template for Downstream PRs (will be copied)