Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made project CAI conversion prefer project number if available #4605

Conversation

melinath
Copy link
Member

Related to GoogleCloudPlatform/terraform-validator#182. Required for GoogleCloudPlatform/terraform-validator#197 to work properly. See also GoogleCloudPlatform/config-validator#161.

Basically the problem here is that CAI export for projects uses project number instead of project ID (the export format is what config-validator expects to receive.) However, project number is only available after the project has been created. For terraform-validator, we still need a way to handle projects prior to creation (and in particular to disambiguate between them) so we want to use project number if available, but still fall back to project id if necessary.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@melinath melinath requested review from a team and slevenick and removed request for a team March 18, 2021 16:52
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Conversion: Diff ( 1 file changed, 26 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177916"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_withEncryptionConfig|TestAccNotebooksInstance_notebookInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177932"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants