Made project CAI conversion prefer project number if available #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-8d4c0ede45a2ac4e017e28362167cfc60d19c281
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to GoogleCloudPlatform/terraform-validator#182. Required for GoogleCloudPlatform/terraform-validator#197 to work properly. See also GoogleCloudPlatform/config-validator#161.
Basically the problem here is that CAI export for projects uses project number instead of project ID (the export format is what config-validator expects to receive.) However, project number is only available after the project has been created. For terraform-validator, we still need a way to handle projects prior to creation (and in particular to disambiguate between them) so we want to use project number if available, but still fall back to project id if necessary.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#4605