Composer

[rlapin-pl]

Remove 2 Composer 1 tests that are failing due to labels with google- prefix.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 80 deletions(-))
google-beta provider: Diff ( 1 file changed, 80 deletions(-))

[modular-magician]

Tests analytics

Total tests: 50
Passed tests: 49
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• composer

🟢 All tests passed!

View the build log

[spapi17]

We can also remove corresponding configurations: testAccComposerEnvironment_update (on line 2588) and testAccComposerEnvironment_webServerCfg (on line 1943), they are not used in any other tests.

[rlapin-pl]

We can also remove corresponding configurations: testAccComposerEnvironment_update (on line 2588) and testAccComposerEnvironment_webServerCfg (on line 1943), they are not used in any other tests.

Done

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 232 insertions(+), 387 deletions(-))
google-beta provider: Diff ( 1 file changed, 232 insertions(+), 394 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• composer

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 210 deletions(-))
google-beta provider: Diff ( 1 file changed, 217 deletions(-))

[modular-magician]

Tests analytics

Total tests: 50
Passed tests: 49
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• composer

🟢 All tests passed!

View the build log

[slevenick]

These tests are valuable and should not be removed without a good reason.

If the specific label is causing the issue, please rework the test to work as intended but to not set this label or add logic to the resource to prevent sending these labels as described in hashicorp/terraform-provider-google#20249 (comment)

[rlapin-pl]

If the specific label is causing the issue, please rework the test to work as intended but to not set this label or add logic to the resource to prevent sending these labels as described in

This label is automatically added "Version 6.0.0 introduced the goog-terraform-provisioned attribution label, which is added automatically to all Terraform-provisioned resources. This is causing problems with the google_composer_environment resource.".

The tests cannot be reworked, because these labels are passed automatically and are not accepted by the API. We are not planning to change API and I got a green light to delete these tests, because 1) Composer 1 creation is not supported anymore 2) Composer 1 update operations are partially covered with other tests.