Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccComposerEnvironment* (User label prefix 'goog-') #20249

Closed
melinath opened this issue Nov 8, 2024 · 5 comments
Closed

Comments

@melinath
Copy link
Collaborator

melinath commented Nov 8, 2024

Impacted tests

  • TestAccComposerEnvironment_update
  • TestAccComposerEnvironment_withWebServerConfig

Affected Resource(s)

  • google_composer_environment

Failure rates

  • 100% since 2024-08-22

Message(s)

Error: Error waiting to update Environment: Error waiting for Updating newly created Environment: Error code 3, message: Errors in: [Web server]; Error messages:
          Failed to deploy the Airflow web server. This might be a temporary issue. You can retry the operation later.
        If the issue persists, it might be caused by problems with permissions or network configuration. For more information, see https://cloud.google.com/composer/docs/troubleshooting-environment-creation
        App Engine Flexible validation error: User label prefix 'goog-' is reserved and cannot be used: goog-terraform-provisioned
          with google_composer_environment.test,

Version 6.0.0 introduced the goog-terraform-provisioned attribution label, which is added automatically to all Terraform-provisioned resources. This is causing problems with the google_composer_environment resource.

Nightly build test history

https://hashicorp.teamcity.com/test/-3074006311885699769?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_NIGHTLYTESTS

b/378146943

@melinath
Copy link
Collaborator Author

melinath commented Nov 8, 2024

@SirGitsalot @rileykarson FYI. I think we'd need the API team to allow setting this label - does that sound right?

@github-actions github-actions bot added forward/review In review; remove label to forward service/composer labels Nov 8, 2024
@melinath melinath removed the forward/review In review; remove label to forward label Nov 8, 2024
@SirGitsalot
Copy link
Collaborator

Yes, if they're rejecting any label with the goog- prefix as that must be coming from within their API implementation. IIRC there was another service that was doing the same and we disabled for that service - @c2thorn was the person who'd remember better than me.

@SarahFrench SarahFrench added this to the Goals milestone Nov 11, 2024
@c2thorn
Copy link
Collaborator

c2thorn commented Nov 11, 2024

Yes, if they're rejecting any label with the goog- prefix as that must be coming from within their API implementation. IIRC there was another service that was doing the same and we disabled for that service - @c2thorn was the person who'd remember better than me.

that was Dataplex: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/dataplex/Datascan.yaml#L19

@rlapin-pl
Copy link

The issue should already be fixed by GoogleCloudPlatform/magic-modules#12463

@melinath
Copy link
Collaborator Author

melinath commented Dec 9, 2024

@melinath melinath closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants