feat: Add capability to replace proto contents in patch-proto #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this new capability to codify the Apigee proto hack that was originally made (manually) in GoogleCloudPlatform#3183. This addresses the suggested change in GoogleCloudPlatform#3183 (review).
yuwenma
reviewed
Dec 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuwenma
reviewed
Dec 11, 2024
| Short: "patches a message in a proto file", | ||
| Long: `Inserts the contents of stdin at the end of the message in the proto file.`, | ||
| Short: "patches a proto file", | ||
| Long: `Patches the contents of stdin into a proto file.`, |
google-oss-prow
bot
merged commit 3e6198d
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this new capability to codify the Apigee proto hack that was originally made (manually) in #3183.
This addresses the suggested changes in #3183 (review) and #3262 (comment).