fix: Codify Apigee proto manual fixes #3262
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following up on suggested change in GoogleCloudPlatform#3183 (review)
jasonvigil
force-pushed
the
make-apigee-proto-changes-permanent
branch
from
9df3525 to
ceea3b0
Compare
|
|
||
| # Fix issue in generated apigee service proto | ||
| # Ref: https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/3183 | ||
| sed -i 's/^ post: "\/v1\/{project=projects\/\*}:provisionOrganization"$/ post: "\/v1\/{name=projects\/\*}:provisionOrganization"/g' ${REPO_ROOT}/mockgcp/apis/mockgcp/cloud/apigee/v1/service.proto |
There was a problem hiding this comment.
This will break Mac users on adding MockGCP.
Can we use mockgcp/tools/patch-proto (like extending the tool to find-and-replace)?
There was a problem hiding this comment.
That's a fair point. Though, I thought we required linux anyway? At least, our environment setup scripts use apt. Though, agreed, it would be better to implement this in mockgcp/tools/patch-proto. I had opted for a quick fix for now, given it will take some more effort to add find-and-replace support to patch-proto
There was a problem hiding this comment.
Ok, I implemented this change in #3351. Going to close this PR in favor of that one.
|
/hold will try to implement this in |
Following up on suggested change in
#3183 (review)