feat: Turn on stricter golden log check in e2e fixture (part 2) #2061
Conversation
yuwenma
force-pushed
the
stricter-test
branch
2 times, most recently
from
bcea8d4 to
ee7fafa
Compare
...ingdashboard/monitoringdashboardbasic/_generated_object_monitoringdashboardbasic.golden.yaml
Outdated
Show resolved
Hide resolved
.../resourcefixture/testdata/basic/alloydb/v1beta1/alloydbcluster/basicalloydbcluster/_http.log
Outdated
Show resolved
Hide resolved
.../project/projectmovedfoldertofolder/_generated_object_projectmovedfoldertofolder.golden.yaml
Outdated
Show resolved
Hide resolved
yuwenma
force-pushed
the
stricter-test
branch
5 times, most recently
from
6a9291f to
982dc42
Compare
| @@ -64,7 +64,7 @@ X-Xss-Protection: 0 | |||
| "selfLink": "https://www.googleapis.com/compute/beta/projects/${projectId}/global/operations/${operationID}", | |||
| "startTime": "2024-04-01T12:34:56.123456Z", | |||
| "status": "RUNNING", | |||
| "targetId": "7780111738275460050", | |||
| "targetId": "1719006515851113983", | |||
There was a problem hiding this comment.
Do we need a rebase for this one? (Hopefully this fails tests also, so it's a good check, though it would be sort of interesting if it didn't!)
There was a problem hiding this comment.
Yes, was waiting for https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/2109/files (now it's merged) when I last updated this PR.
There was a problem hiding this comment.
Do we need a rebase for this one? (Hopefully this fails tests also, so it's a good check, though it would be sort of interesting if it didn't!)
BTW, yes it did fail the PRESUBMIT check https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/9626625776/job/26552788995
There was a problem hiding this comment.
The monitoring dashboard golden log reflects the outcome of the Direct Controller, rather than the TF-based controller.
There was a problem hiding this comment.
This file is a replacement of the tests-e2e-direct.sh, which focuses on the more complicated step-by-step scenario tests.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit bae0c85
into
GoogleCloudPlatform:master
Turn on the stricter golden log check in fixture presubmit. This is the second part and needs #1934 to merge first.