-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Turn on stricter golden log check in e2e fixture (part 1) #1934
feat: Turn on stricter golden log check in e2e fixture (part 1) #1934
Conversation
So I don't know if all our tests are consistent with record-gcp yet. But ... I like this idea ... we can at least require that compare-mock produces stable output, and verify it! |
In this PR, I am trying to see how big the difference is and how much work need to be done to turn on the strict http log check. |
I've been thinking about this ... you're right, we should have done this from the start. It might be that our mockgcp results aren't 100% equal to GCP in all cases. But we still get a lot more signal by checking these values against mockgcp than by not checking them! |
2d99f8f
to
53be30c
Compare
@@ -24,7 +24,7 @@ cd ${REPO_ROOT}/ | |||
echo "Downloading envtest assets..." | |||
export KUBEBUILDER_ASSETS=$(go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest use -p path) | |||
|
|||
export KCC_USE_DIRECT_RECONCILERS=MonitoringDashboard | |||
KCC_USE_DIRECT_RECONCILERS=MonitoringDashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need export, otherwise it doesn't apply to subsequent requests, but as this is passing tests let's go with it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fix this in Part 2. Want to use this as an example to highlight some changes.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0ce0cde
into
GoogleCloudPlatform:master
Description
This PR adds the golden object log and mock http log to all existing mocked GCP resources. Once it goes in, we can turn on the presubmit check in #2061
Known Caveats
We have not tuned all the existing Mock GCP to make its log output the same as the real GCP log yet, which means these mock gcp server may need improvements during development, and the golden log needs to be re-generated if necessary.
Requirements for ConfigConnector Contributors
We want to turn on this golden log check now and expect it to be used (and maintained) in the following cases: