Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes parity tests failures in windows machines. #1830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes parity tests failures in windows machines. #1830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion gslib/tests/test_rsync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2999,7 +2999,13 @@ def _Check1():

def _Check2():
"""Tests that a regex with a pipe works as expected."""
_check_exclude_regex('^data|[bc]$', set(['/a']))
if self._use_gcloud_storage and IS_WINDOWS:
# Pipe character should be escaped for windows cmd.
# It appears that ^ is not escaping | as expected but ^^^ does So
# changing input for windows shim mode gsutil test.
_check_exclude_regex('^data^^^|[bc]$', set(['/a']))
else:
_check_exclude_regex('^data|[bc]$', set(['/a']))

_Check2()

Expand Down